Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing in GitHub CI #60

Open
stefan6419846 opened this issue Jan 12, 2024 · 3 comments
Open

Testing in GitHub CI #60

stefan6419846 opened this issue Jan 12, 2024 · 3 comments

Comments

@stefan6419846
Copy link
Contributor

At the moment, it seems like only the docs are checked when submitting a PR - and only for Python 3.9. This does not seem to be sufficient, as test breakages are not visible automatically by this, for example because of another Python version in the supported range 3.7 to 3.12.

When already at it: It seems like this repository does not have any contribution docs like ScanCode Toolkit: https://github.com/nexB/scancode-toolkit/blob/develop/CONTRIBUTING.rst Do the same rules apply here?

@stefan6419846 stefan6419846 changed the title Testing in CI Testing in GitHub CI Jan 12, 2024
@pombredanne
Copy link
Member

When already at it: It seems like this repository does not have any contribution docs like ScanCode Toolkit: https://github.com/nexB/scancode-toolkit/blob/develop/CONTRIBUTING.rst Do the same rules apply here?

Yes, that's an oversight
In the past commoncode was in the repo as scancode
Then we split it to reuse as a discrete package
With the advent of flot https://github.com/pombredanne/flot/ we may merge commoncode back in scancode and still have the benefit of discrete components

@pombredanne
Copy link
Member

NB: 3.7 is a dead snake... we will drop support for it soon.

@stefan6419846
Copy link
Contributor Author

Thanks for the clarification. I am aware that Python 3.7 is EOL, but I just wanted to include it into the list as the package configuration declares this as the minimum Python version for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants