Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U-Boot: GPL-1.0-only, GPL-2.0-only and GPL-3.0-only false positives #1928

Closed
armijnhemel opened this issue Feb 17, 2020 · 3 comments
Closed
Labels

Comments

@armijnhemel
Copy link
Contributor

Description

u-boot-2010.06/board/netphone/netphone.c

recognized as:

GPL-1.0-only
GPL-2.0-only
GPL-2.0-or-later
GPL-3.0-only

but the file is GPL-2.0-only only

How To Reproduce

Tell us how to reproduce the issue.

System configuration

For bug reports, it really helps us to know:

  • What OS are you running on? (Windows/MacOS/Linux)
  • What version of scancode-toolkit was used to generate the scan file?
  • What installation method was used to install/run scancode? (pip/source download/other)
@armijnhemel
Copy link
Contributor Author

u-boot-2010.06/board/netta2/netta2.c
u-boot-2010.06/board/stx/stxxtc/stxxtc.c

@pombredanne
Copy link
Member

Good catch!
there are a bunch of defines and symbols GPL0, GPL1, GPL2 and GPL3 that are the sources of the false positives

125 #define GPL1_0000       0x00000000
126 #define GPL1_0001       0x00040000
127 #define GPL1_1110       0x00080000
128 #define GPL1_1111       0x000C0000
129 
130 #define GPL2_0000       0x00000000
131 #define GPL2_0001       0x00010000
132 #define GPL2_1110       0x00020000
133 #define GPL2_1111       0x00030000
134 
135 #define GPL3_0000       0x00000000
136 #define GPL3_0001       0x00004000
137 #define GPL3_1110       0x00008000
138 #define GPL3_1111       0x0000C000

@pombredanne
Copy link
Member

This has been fixed and merged in develop. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants