Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dgraph license reference not recognized #3984

Open
armijnhemel opened this issue Nov 14, 2024 · 2 comments
Open

dgraph license reference not recognized #3984

armijnhemel opened this issue Nov 14, 2024 · 2 comments
Labels

Comments

@armijnhemel
Copy link
Contributor

Description

Dgraph license references in the Dgraph Git repository are not scanned correctly. When scanning for example https://github.com/dgraph-io/dgraph/blob/main/dgraph/cmd/root_ee.go I get the following result:

      "path": "root_ee.go",
      "type": "file",
      "detected_license_expression": "polyform-free-trial-1.0.0",
      "detected_license_expression_spdx": "LicenseRef-scancode-polyform-free-trial-1.0.0",
      "license_detections": [
        {
          "license_expression": "polyform-free-trial-1.0.0",
          "license_expression_spdx": "LicenseRef-scancode-polyform-free-trial-1.0.0",
          "matches": [
            {
              "license_expression": "polyform-free-trial-1.0.0",
              "license_expression_spdx": "LicenseRef-scancode-polyform-free-trial-1.0.0",
              "from_file": "root_ee.go",
              "start_line": 7,
              "end_line": 11,
              "matcher": "3-seq",
              "score": 61.22,
              "matched_length": 30,
              "match_coverage": 61.22,
              "rule_relevance": 100,
              "rule_identifier": "polyform-free-trial-1.0.0_1.RULE",
              "rule_url": "https://github.com/nexB/scancode-toolkit/tree/develop/src/licensedcode/data/rules/polyform-free-trial-1.0.0_1.RULE"
            }
          ],
          "identifier": "polyform_free_trial_1_0_0-5578fe3c-6f9d-f096-20fc-09d81a96b74a"
        }
      ],
      "license_clues": [],
      "percentage_of_license_text": 28.04,
      "scan_errors": []

How To Reproduce

Tell us how to reproduce the issue.

$ ./scancode -l --json-pp=/tmp/dgraph.json /tmp/root_ee.go

System configuration

For bug reports, it really helps us to know:

  • What OS are you running on? Linux
  • What version of scancode-toolkit was used to generate the scan file? v32.3.0-14-g65e1c2db47
  • What installation method was used to install/run scancode? source
@alok1304
Copy link

alok1304 commented Dec 26, 2024

@pombredanne I think we have to add RULE for Dgraph.
I also checked this file, and I got the same output, so there is a bug. In the root_ee.go file, there is no license_expression for polyform-free-trial-1.0.0.

Am i right??

@alok1304
Copy link

@pombredanne I think there is no bug because,
in polyform-free-trial-1.0.0_1.RULE
Screenshot 2024-12-26 212036
and in root_ee.go file
Screenshot 2024-12-26 212149
we can clearly see RULE file is match with root_ee.go because of line 7 to 11 in root_ee.go file is same as in polyform-free-trial-1.0.0_1.RULE from line 9 to 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants