Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new BSD license rule #4040

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

NucleonGodX
Copy link

@NucleonGodX NucleonGodX commented Dec 26, 2024

Fixes #4018

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁

Signed-off-by: NucleonGodX manitsingh018@gmail.com

@NucleonGodX NucleonGodX changed the title Added new-bsd variant as a rule Added new BSD variant as a rule Dec 26, 2024
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looking good!
Do you mind to amend the commit message?
We like to use imperative style.
Rather than "new bsd variant added as a rule", what about:

"Add BSD license detection rule #4018"

We have some doc on how to write good commit messages: See https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html

@pombredanne
Copy link
Member

Please also rename your PR using the imperative style, and apply the same approach to your other PRs.

Signed-off-by: NucleonGodX <racerpro41@gmail.com>
@NucleonGodX NucleonGodX changed the title Added new BSD variant as a rule Add new BSD license rule Dec 31, 2024
@NucleonGodX
Copy link
Author

NucleonGodX commented Dec 31, 2024

Thanks for the suggestions @pombredanne , I've implemented them here and in other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new BSD minor variant as a rule
2 participants