Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle possible duplication of constraints in VersionRange #45

Open
keshav-space opened this issue Mar 11, 2022 · 0 comments · May be fixed by #69
Open

Handle possible duplication of constraints in VersionRange #45

keshav-space opened this issue Mar 11, 2022 · 0 comments · May be fixed by #69
Labels
2-next

Comments

@keshav-space
Copy link
Member

keshav-space commented Mar 11, 2022 •
edited
Loading

Eliminate the possibility of constraints duplication in VersionRange and add some tests to validate the same.

>>> from univers.version_range import NginxVersionRange
>>> range=NginxVersionRange.from_native("1.5.0+, 1.4.1+, 1.4.0+")
>>> str(range)
'vers:nginx/>=1.4.0|>=1.4.1|<1.5.0|<1.5.0|>=1.5.0'

Context: #42 (comment)
@keshav-space keshav-space mentioned this issue Mar 11, 2022
Merged
keshav-space added a commit to keshav-space/univers that referenced this issue May 11, 2022
@keshav-space
fix the constraint duplication in VersionRange
ec96179 
- add test for constraint duplicaton
- closes: aboutcode-org#45

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
keshav-space added a commit to keshav-space/univers that referenced this issue May 11, 2022
@keshav-space
fix the constraint duplication in VersionRange
4bac91c 
- add test for constraint duplicaton
- closes: aboutcode-org#45

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space keshav-space linked a pull request May 11, 2022 that will close this issue
Draft
keshav-space added a commit to keshav-space/univers that referenced this issue May 17, 2022
@keshav-space
fix the constraint duplication in VersionRange
328ba06 
- add test for constraint duplicaton
- closes: aboutcode-org#45

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
keshav-space added a commit to keshav-space/univers that referenced this issue May 25, 2022
@keshav-space
fix the constraint duplication in VersionRange
df34260 
- add test for constraint duplicaton
- closes: aboutcode-org#45

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2-next
Projects
04-VulnerableCode Data Quality and next
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix constraints duplication keshav-space/univers
2 participants
@pombredanne @keshav-space