Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"fixing" or "fixed" -- how should we name a package that fixes a vulnerability? #1301

Closed
johnmhoran opened this issue Sep 14, 2023 · 14 comments
Assignees

Comments

@johnmhoran
Copy link
Member

A serious question. Please do contribute your thoughts. We will discuss on the next weekly jit.si.

  • A vulnerability is "fixed by" a package.
  • A vulnerability is "affecting" a package.
  • A package is "fixing" a vulnerability.
  • A package is "affected by" a vulnerability.

This is what we suggest after a discussion with @pombredanne .

TODO:

  • Check the words used by NVD, GHSA, OSV et al./etc.
@johnmhoran johnmhoran self-assigned this Sep 14, 2023
@mjherzog
Copy link
Member

mjherzog commented Sep 15, 2023

Please also check:

  • CycloneDX
  • SPDX (not sure if they have anything but they document many relationship pairs)
  • Snyk
  • Sonatype
  • JFrog

@johnmhoran
Copy link
Member Author

Thank you @mjherzog -- I'll do that.

@mjherzog
Copy link
Member

It seems that the affect/fix terminology is well-established. I recommend slight changes in wording as follows:

  • A vulnerability is "fixed by" a package.
  • A vulnerability "affects" a package.
  • A package "fixes" a vulnerability.
  • A package is "affected by" a vulnerability.

@DennisClark
Copy link
Member

I second the recommendation

@johnmhoran
Copy link
Member Author

I will paste some screen shots here in a little while illustrating our decision at today's jit.si meeting to keep the naming as it is and has been for a while on my issue #1228 VCIO UI.

@johnmhoran
Copy link
Member Author

Some representative examples. @DennisClark you'll like this first one. ;-)

image

@johnmhoran
Copy link
Member Author

image

@johnmhoran
Copy link
Member Author

image

@johnmhoran
Copy link
Member Author

image

@johnmhoran
Copy link
Member Author

image

@johnmhoran
Copy link
Member Author

image

@johnmhoran
Copy link
Member Author

I'm done.

@DennisClark
Copy link
Member

@johnmhoran thanks for the concrete examples. I think that they illustrate the best approach to take.

@pombredanne
Copy link
Member

Closed in favor of #1520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants