Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The query for affected and fixed packages should be abstracted as methods on the models (and/or on a model manager) #595

Closed
Hritik14 opened this issue Jan 25, 2022 · 4 comments

Comments

@Hritik14
Copy link
Collaborator

Hritik14 commented Jan 25, 2022

The query for affected and fixed packages should be abstracted as methods on the models (and/or on a model manager)

Originally posted by @pombredanne in #525 (comment)

Currently we query for affected and fixed packages as: https://github.com/nexB/vulnerablecode/blob/67fc00e5a8dbdf690f1c1b0d627da0d06322adb9/vulnerabilities/views.py#L81-L87

This needs to be abstracted as model methods.

Related:

@remote007
Copy link

@Hritik14 @pombredanne .. is this issue open for contribution ?

@poju3185
Copy link
Contributor

Hi @Hritik14 and @pombredanne, can I work on this issue, or has it already been solved?

@pombredanne
Copy link
Member

We now have these at least in https://github.com/nexB/vulnerablecode/blob/457f8f8ce8550502714d3f19d914c5ab2409c935/vulnerabilities/models.py#L651-L670

  • affected_by
  • fixing

Closing this now. Note that we still need to rework the models as described in #966

@pombredanne
Copy link
Member

We now have these at least in https://github.com/nexB/vulnerablecode/blob/457f8f8ce8550502714d3f19d914c5ab2409c935/vulnerabilities/models.py#L651-L670

  • affected_by
  • fixing

Closing this now. Note that we still need to rework the models as described in #966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants