Fails to login #2

johntdyer · 2023-11-16T19:57:55Z

I am trying to log in and I'm getting the following error when running the UI

╰─ ENABLE_UI=true yarn start                                                                                     ─╯

yarn run v1.22.19
$ node index.js
(node:49527) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
HCTB-API is listening on port 8080 :)
[Info] Browser instance started
[Info] Opened a new page
[Info] Logging in to Here Comes The Bus
[Info] Parsing cookie
/Users/jdyer/Project/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:271
        throw new Error('Evaluation failed: ' + (0, util_js_1.getExceptionMessage)(exceptionDetails));
              ^

Error: Evaluation failed: TypeError: Cannot read properties of undefined (reading 'value')
    at pptr://__puppeteer_evaluation_script__:2:72
    at ExecutionContext._ExecutionContext_evaluate (/Users/jdyer/Project/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:271:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async ExecutionContext.evaluate (/Users/jdyer/Project/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:118:16)
    at async JSHandle.evaluate (/Users/jdyer/Project/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/JSHandle.js:91:16)
    at async ElementHandle.$$eval (/Users/jdyer/Project/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/ElementHandle.js:192:24)
    at async /Users/jdyer/Project/hctb-api/index.js:99:19

Node.js v21.2.0
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

The text was updated successfully, but these errors were encountered:

johntdyer · 2023-11-16T20:02:07Z

Also I tried using POST and got the same error

╭─    ~/Projects/hctb-api    main !1 ?1    INT ✘  ▼  Project   03:00:41 PM  ─╮
╰─ curl -X POST -d '{}' 'http://127.0.0.1:8080/api/login?user=xxxxxxxx%40gmail.com&pass=xxxxxxxxxx%23&code=12345'
curl: (52) Empty reply from server
╭─    ~/Projects/hctb-api    main !1 ?1 
╰─

$ node index.js
(node:50031) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
HCTB-API is listening on port 8080 :)
[Info] Browser instance started
[Info] Opened a new page
[Info] Logging in to Here Comes The Bus
[Info] Parsing cookie
/Users/jdyer/Project/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:271
        throw new Error('Evaluation failed: ' + (0, util_js_1.getExceptionMessage)(exceptionDetails));
              ^

Error: Evaluation failed: TypeError: Cannot read properties of undefined (reading 'value')
    at pptr://__puppeteer_evaluation_script__:2:72
    at ExecutionContext._ExecutionContext_evaluate (/Users/jdyer/Project/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:271:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async ExecutionContext.evaluate (/Users/jdyer/Project/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:118:16)
    at async JSHandle.evaluate (/Users/jdyer/Project/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/JSHandle.js:91:16)
    at async ElementHandle.$$eval (/Users/jdyer/Project/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/ElementHandle.js:192:24)
    at async /Users/jdyer/Project/hctb-api/index.js:99:19

Node.js v21.2.0
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
╭─    ~/Projects/hctb-api    main !1 ?1 

Thanks again, Super love the idea of this !!!!

djuntgen · 2023-11-17T04:42:32Z

Running into the same problem

HCTB-API is listening on port 8080 :)
[Info] Browser instance started
[Info] Opened a new page
[Info] Logging in to Here Comes The Bus
[Info] Parsing cookie
/opt/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:271
        throw new Error('Evaluation failed: ' + (0, util_js_1.getExceptionMessage)(exceptionDetails));
              ^

Error: Evaluation failed: TypeError: Cannot read properties of undefined (reading 'value')
    at pptr://__puppeteer_evaluation_script__:2:72
    at ExecutionContext._ExecutionContext_evaluate (/opt/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:271:15)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async ExecutionContext.evaluate (/opt/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:118:16)
    at async JSHandle.evaluate (/opt/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/JSHandle.js:91:16)
    at async ElementHandle.$$eval (/opt/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/ElementHandle.js:192:24)
    at async /opt/hctb-api/index.js:99:19

Node.js v18.13.0
root@debian:/opt/hctb-api#

dispherical · 2023-11-20T18:32:48Z

That’s quite odd, I was working on adding Home Assistant integration and it was working just fine.

I’m currently away from my laptop until tomorrow night so I can’t diagnose the problem further at the moment so I apologise. From what it seems, some accounts may not have the ability to get the information described on line 99.

I only have access to a phone right now so I can’t do much. Deploying from the quickfix-20nov branch will help, but will make /api/session inoperable as it will no longer get the data required.

https://github.com/aboutdavid/hctb-api/tree/quickfix-20nov

djuntgen · 2023-11-20T23:42:10Z

Gave it a try, different / new error. I think its great that you are thinking about HA integration!

HCTB-API is listening on port 8080 :)
[Info] Browser instance started
[Info] Opened a new page
[Info] Logging in to Here Comes The Bus
[Info] Parsing cookie
/opt/hctb-api/index.js:133
      legacyID: value.person,
                ^

ReferenceError: value is not defined
    at /opt/hctb-api/index.js:133:17
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Node.js v18.13.0
root@debian:/opt/hctb-api#

dispherical · 2023-11-21T00:13:27Z

That’s super odd. Could you try starting it with a head and see if it successfully logs into the dashboard?

https://github.com/aboutdavid/hctb-api/blob/b229ae47b578b7d9f034dc840ce4e3157a3df267/index.js#L60
Try and see if you can give it a head here by setting headless to false

If you can’t, that’s fine, I just think there could either be different account types or it could just fail to notice that you’re not logged in or something else

dispherical · 2023-11-21T01:00:05Z

I've managed to somehow spin up a service and used mine and a couple of friend's logins and I can't reproduce this issue. I think the theory of different account types could be true. By the way, are there multiple people associated with your account? As in multiple students connected to one account?

johntdyer · 2023-11-21T02:04:53Z

Yes, for mine I have two bus routes, one for my son in middle school and one for my daughter in high school. I would be happy temporarily change the credentials and then privately share them with you for testing if you think thats whats needed

…

On Nov 20, 2023, at 8:00 PM, David M ***@***.***> wrote: I've managed to somehow spin up a service and used mine and a couple of friend's logins and I can't reproduce this issue. I think the theory of different account types could be true. By the way, are there multiple people associated with your account? As in multiple students connected to one account? — Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAOG6XR3QU6FHFECC5M36DYFP4KBAVCNFSM6AAAAAA7OWXIOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQGA2DONBSHA>. You are receiving this because you authored the thread.

dispherical · 2023-11-21T02:28:14Z

Ah, I think I know the issue. Also, I don't think it would be wise to send credentials to anybody, even if they are changed, as malicious people roam everywhere on the internet. I made this with one person only in my account, so I wasn't able to test all of the edge cases. I'll attempt to fix this later this week once I have stable internet.

djuntgen · 2023-11-21T03:06:01Z

I have 2 different bus routes as well. Added headless: false to puppeterr.

root@debian:/opt/hctb-api# vi index.js 
root@debian:/opt/hctb-api# ENABLE_UI=true npm start

> hctbb-api@2.0.0 start
> node index.js

HCTB-API is listening on port 8080 :)
/opt/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/util.js:317
    const timeoutError = new Errors_js_1.TimeoutError(`waiting for ${taskName} failed: timeout ${timeout}ms exceeded`);
                         ^

TimeoutError: waiting for target failed: timeout 30000ms exceeded
    at waitWithTimeout (/opt/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/util.js:317:26)
    at Browser.waitForTarget (/opt/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/common/Browser.js:405:56)
    at ChromeLauncher.launch (/opt/hctb-api/node_modules/puppeteer/lib/cjs/puppeteer/node/ChromeLauncher.js:100:31)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async /opt/hctb-api/index.js:60:19

Node.js v18.13.0
root@debian:/opt/hctb-api#

UPDATE

I ran {headless: false} on my Macbook vs. Proxmox LXC to launch Chromium. Good news is that the login does work, and defaults it to the first bus route. Bad news that it times out. I think the issue here is with multiple bus routes under one account. The "API" will need a way to identify which bus route.

I think you'll need to add a passenger field/value somewhere in login credientails.

dispherical · 2023-12-19T14:16:26Z

Hi, I recently got around to trying to make this work. I'll push out an update when I am finished with my finals.

jrittenh · 2024-01-31T01:17:05Z

Just a ping from 2024 as someone else hitting this error with two bus routes.

dispherical · 2024-03-20T16:18:15Z

I think I might have a solution. I will try and add a new method (/api/passengers), which should return with a list of names and UUIDs. It will also return a "cookie" so you can skip straight to /api/session.

dispherical · 2024-03-20T16:46:56Z

{
    "success": true,
    "cookie": ".ASPXFORMSAUTH=... ",
    "passengers": [
        {
            "text": "David",
            "value": "..."
        }
    ]
}

I'm unsure if every passenger has a different time UUID, however. I could attempt to omit that and just use the names of the times instead of the UUID.

dispherical · 2024-03-22T01:18:24Z

I think a temporary solution would be commenting out this section:

const value = await page.$$eval('option[selected="selected"]', (el) => {
  return { name: el[1].innerHTML, person: el[1].value, time: el[2].value };
});

Although, that makes /api/session pretty much useless. For now, I'll push an API change which allows for the disabling of this via the query selectors.

johntdyer changed the title ~~Fais to~~ Fais to login Nov 16, 2023

dispherical changed the title ~~Fais to login~~ Fails to login Nov 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fails to login #2

Fails to login #2

johntdyer commented Nov 16, 2023 •

edited

Loading

johntdyer commented Nov 16, 2023

djuntgen commented Nov 17, 2023

dispherical commented Nov 20, 2023

djuntgen commented Nov 20, 2023

dispherical commented Nov 21, 2023 •

edited

Loading

dispherical commented Nov 21, 2023

johntdyer commented Nov 21, 2023 via email

dispherical commented Nov 21, 2023

djuntgen commented Nov 21, 2023 •

edited

Loading

dispherical commented Dec 19, 2023

jrittenh commented Jan 31, 2024 •

edited

Loading

dispherical commented Mar 20, 2024 •

edited

Loading

dispherical commented Mar 20, 2024

dispherical commented Mar 22, 2024

Fails to login #2

Fails to login #2

Comments

johntdyer commented Nov 16, 2023 • edited Loading

johntdyer commented Nov 16, 2023

djuntgen commented Nov 17, 2023

dispherical commented Nov 20, 2023

djuntgen commented Nov 20, 2023

dispherical commented Nov 21, 2023 • edited Loading

dispherical commented Nov 21, 2023

johntdyer commented Nov 21, 2023 via email

dispherical commented Nov 21, 2023

djuntgen commented Nov 21, 2023 • edited Loading

UPDATE

dispherical commented Dec 19, 2023

jrittenh commented Jan 31, 2024 • edited Loading

dispherical commented Mar 20, 2024 • edited Loading

dispherical commented Mar 20, 2024

dispherical commented Mar 22, 2024

johntdyer commented Nov 16, 2023 •

edited

Loading

dispherical commented Nov 21, 2023 •

edited

Loading

djuntgen commented Nov 21, 2023 •

edited

Loading

jrittenh commented Jan 31, 2024 •

edited

Loading

dispherical commented Mar 20, 2024 •

edited

Loading