Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RTL in Blazor Project #8000

Closed
buaziz opened this issue Mar 9, 2021 · 6 comments
Closed

Support RTL in Blazor Project #8000

buaziz opened this issue Mar 9, 2021 · 6 comments
Assignees
Labels

Comments

@buaziz
Copy link
Contributor

buaziz commented Mar 9, 2021

No description provided.

@stsrki
Copy link
Contributor

stsrki commented Mar 9, 2021

How would this even work? Blazor projects are using Blazorise and it is not well suited for RTL. At least in the current state. For example, let's say we take one basic example with enum TextAlignment which has Left and Right. By default, everything on a page is left aligned. And when we set some paragraph alignment to TextAlignment.Right then that one element would move to the right.

Now, what if we switch everything and enable RTL. Do we just switch left and right. That would mean our previous example would make TextAlignment.Right to go to the left. While it saying it is on the right. I don't think it is the right way to work like that.

I propose to rename everything from Left and Right to something like Near and Far. It makes more sense in LTR and RTL modes. But it would be a breaking change and would need to change a lot of stuff.

@hikalkan What do you think?

@stsrki
Copy link
Contributor

stsrki commented Mar 9, 2021

It also seems Bootstrap RTL is only available with v5 while v4 needs external dependency to work. Bulma provider supports it from v0.9.

https://dev.to/hus_hmd/rtl-support-lands-in-bootrstrap-and-bulma-3hom

@buaziz
Copy link
Contributor Author

buaziz commented Mar 11, 2021

@stsrki will this be planned as currently there is no label?

having this feature or not will result in our decision to go ahead with Blazor or do the UI on Angular.

@stsrki
Copy link
Contributor

stsrki commented Mar 11, 2021

Yes, I believe it will be ready. The ticket with the label is here #5517

@stsrki
Copy link
Contributor

stsrki commented Mar 11, 2021

Sorry I answered the wrong ticket with the last message 😅

Now back to your question. Unfortunately, I still have no open ticket or label for RTL support. This is the first time it was requested to tell you the truth.

@stale
Copy link

stale bot commented May 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label May 12, 2021
@stale stale bot closed this as completed May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants