Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: reflection doesn't work with param decorators #6

Closed
Hotell opened this issue Jul 24, 2018 · 10 comments
Closed

bug: reflection doesn't work with param decorators #6

Hotell opened this issue Jul 24, 2018 · 10 comments
Labels
bug Something isn't working

Comments

@Hotell
Copy link

Hotell commented Jul 24, 2018

after #3 was closed, injection-js will pass although app will error out.
Everything is annotated properly ( I have tests for it and it works with reflect-metadata )

Issue might be with injecting non Class references via @Inject() param decorator. Just shooting in the dark here...

image

axios-http source:

https://github.com/Hotell/axios-http/blob/master/src/interceptor.ts#L49-L52

You can test it here:

https://codesandbox.io/s/6zx71n084n

@abraham abraham added the bug Something isn't working label Jul 24, 2018
@abraham
Copy link
Owner

abraham commented Jul 24, 2018

Fix in v0.3.0

@abraham abraham closed this as completed Jul 24, 2018
@Hotell
Copy link
Author

Hotell commented Jul 24, 2018

gonna test it ASAP ! keep rockin @abraham 💪

@abraham
Copy link
Owner

abraham commented Jul 24, 2018

Note that /dist/reflect is now removed so you just use the main entry. import '@abraham/reflection.

@Hotell
Copy link
Author

Hotell commented Jul 24, 2018

and we have a winner ;) thanks for prompt fixes dude !

image

@abraham
Copy link
Owner

abraham commented Jul 24, 2018

Nice!

@Hotell
Copy link
Author

Hotell commented Jul 24, 2018

Before:

image

After:

image

👌👌👌👌👌👌👌👌👌👌👌👌👌👌👌👌👌👌👌👌👌👌👌👌👌👌👌

@abraham
Copy link
Owner

abraham commented Jul 24, 2018

giphy

@Hotell
Copy link
Author

Hotell commented Jul 24, 2018

Interesting, on codesandbox it still doesn't work :-/ but locally all good

image

@Hotell
Copy link
Author

Hotell commented Jul 25, 2018

codesandbox/codesandbox-client#1004

@abraham
Copy link
Owner

abraham commented Jul 25, 2018

Interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants