Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment for formats.py in the wrong place #184

Closed
jaraco opened this issue Jul 17, 2024 · 0 comments · Fixed by #196
Closed

Comment for formats.py in the wrong place #184

jaraco opened this issue Jul 17, 2024 · 0 comments · Fixed by #196

Comments

@jaraco
Copy link

jaraco commented Jul 17, 2024

I noticed these comments look out of place:

# None => not cached yet
# False => cache not available

They were probably meant to apply to the self.downloaded property.

Consider this instead:

diff --git a/setuptools/config/_validate_pyproject/formats.py b/setuptools/config/_validate_pyproject/formats.py
index aacf4092b..a76a1d147 100644
--- a/setuptools/config/_validate_pyproject/formats.py
+++ b/setuptools/config/_validate_pyproject/formats.py
@@ -162,12 +162,15 @@ class _TroveClassifier:
     """
 
     downloaded: typing.Union[None, "Literal[False]", typing.Set[str]]
+    """
+    None => not cached yet
+    False => unavailable
+    set => cached values
+    """
 
     def __init__(self) -> None:
         self.downloaded = None
         self._skip_download = False
-        # None => not cached yet
-        # False => cache not available
         self.__name__ = "trove_classifier"  # Emulate a public function
 
     def _disable_download(self) -> None:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant