Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step 2: Run Abseil Tests in Linux #107

Closed
JonathanDCohen opened this issue May 2, 2018 · 3 comments
Closed

Step 2: Run Abseil Tests in Linux #107

JonathanDCohen opened this issue May 2, 2018 · 3 comments
Labels
cmake related to CMake support

Comments

@JonathanDCohen
Copy link
Contributor

This is the prerequisite for any upgrades or refactorings we hope to accomplish -- can't be sure of anything without tests! As of this writing there is an internal change out which accomplishes this, so we should be able to keep moving forward soon.
@JonathanDCohen JonathanDCohen added the cmake related to CMake support label May 2, 2018
@JonathanDCohen
Copy link
Contributor Author

#106

@JonathanDCohen
Copy link
Contributor Author

This change is coming soon and will add a new cmake option: ABSL_USE_GOOGLETEST_HEAD. This currently defaults to OFF, but when ON we will download Googletest source at config time and use that to run our tests -- this will default to ON some time in the future, after announcement and discussion so everyone can change their build scripts if necessary. Our CI builds use this option.

@JonathanDCohen
Copy link
Contributor Author

We now run our tests in Linux. Please see absl/CMakeLists.txt and the CMake README for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmake related to CMake support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JonathanDCohen