Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 3: Update Minimum Required Version #108

Closed
JonathanDCohen opened this issue May 2, 2018 · 4 comments
Closed

Step 3: Update Minimum Required Version #108

JonathanDCohen opened this issue May 2, 2018 · 4 comments
Assignees
Labels
cmake related to CMake support

Comments

@JonathanDCohen
Copy link
Contributor

JonathanDCohen commented May 2, 2018

Abseil currently requires an ancient version of CMake. We need to support at least CMake 3.0.0 as the first "modern" release of CMake. We be slightly stricter if there are some critical bugfixes after 3.0.0, but as a low-level library we need to be very careful about bumping this number upwards.

This is sequenced right after tests as about the smallest change we could make to give a run to our testing infrastructure. It is also something we want to do sooner rather than later as we want to avoid breaking users over this as much as possible.

@JonathanDCohen JonathanDCohen added the cmake related to CMake support label May 2, 2018
@JonathanDCohen JonathanDCohen self-assigned this May 2, 2018
@JonathanDCohen
Copy link
Contributor Author

#106

@JonathanDCohen JonathanDCohen changed the title Step 3: Update Minimum Required Version to 3.0.0 Step 3: Update Minimum Required Version May 10, 2018
@JonathanDCohen
Copy link
Contributor Author

The current thought is to set our minimum_required_version to cmake 3.1.2 to allow us to use CMAKE_CXX_STANDARD directly as opposed to our kludgey ABSL_STD_CXX_FLAG. We are very curious who and how this may break people and would like to hear thoughts on the matter

@JonathanDCohen
Copy link
Contributor Author

That plan was taken. We now use standard env and Cmake variables where we can. This includes $CC and $CXX to set the compiler, and the use of CMAKE_CXX_STANDARD. We don't use the CXX_STANDARD flag anywhere else so abseil should adapt language level to whatever project it is compiled as a part of.

@MikeGitb
Copy link

MikeGitb commented Aug 7, 2018

@JonathanDCohen: AFAIK, ABSL_STD_CXX_FLAG is still used:

# -std=X
set(CMAKE_CXX_FLAGS "${ABSL_STD_CXX_FLAG} ${CMAKE_CXX_FLAGS}")

Are you refering to some internal branch of abseil?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake related to CMake support
Projects
None yet
Development

No branches or pull requests

2 participants