Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for Flutter 2 #6

Open
AndrewM- opened this issue Mar 17, 2021 · 1 comment
Open

Changes for Flutter 2 #6

AndrewM- opened this issue Mar 17, 2021 · 1 comment

Comments

@AndrewM-
Copy link

To get the project to work in Flutter 2 I had to make a couple of changes to the supporting packages:

    • In picture_stream.dart, I changed the word 'DiagnosticableMixin' to 'Diagnosticable'
    • In picture_provider.dart I chanded line 49 or 50 to locale: context != null ? Localizations.localeOf(context) : null,

For item 2, Flutter 2 handles nulls differently and the NullOK flag has to be removed. More info here: https://docs.google.com/document/d/1LKBL0S1uyhACDiUXILhLKFZH8Cpl_w3mXjHgaE8_--U/edit#heading=h.pub7jnop54q0

To get at these files, find the import statement in home_screen.dart import 'package:flutter_svg/flutter_svg.dart'; and use the goto definition menu option (VS Code). This will take you to flutter_svg.dart which lists the packages in items 1 and 2. Open the definition to see the code.

@FMorschel
Copy link

FMorschel commented May 11, 2021

Hi! As I've said at #2, the author said the license it's MIT, so, if you have these changes working still and have the time, submit a pull request, maybe someone else wants them and it would be easier to find them. Or even just fork this repo and tell people about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants