Rewrite on('didInsertElement') and on('willDestroyElement') to override and call super instead

[abuiles]

cc @fivetanley

[lolmaus]

Why?

[knownasilya]

Those events have hooks, which is the new standard way of changing them. It prevents unexpected behavior, especially if you have multiple events, which you cannot do with the hooks.

[lolmaus]

I've seen recommendations to migrate from hooks to events. O-o

[knownasilya]

Maybe for actual browser events? Like click or submit?

[lolmaus]

Found a very old example: https://dockyard.com/blog/2014/04/28/dont-override-init

But I've seen more recent ones with the same idea.

I personally haven't seen any difference with the two approaches, unless I need to control the order, but I've never had a practical case of that.

[knownasilya]

That post is kinda old 😸 and he even mentions using super at the end, which would require you to use hooks. Plus if you look at code examples or addons from core team members, they always use the hooks.