Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailer.sending event does not work with laraveldkim #3

Open
shoaibnawaz opened this issue Dec 9, 2015 · 2 comments
Open

mailer.sending event does not work with laraveldkim #3

shoaibnawaz opened this issue Dec 9, 2015 · 2 comments

Comments

@shoaibnawaz
Copy link
Contributor

I found that your implementation does not let default event feature to trigger and the reason
I investigated was that missing third parameter($app['events']) while instantiating the Mailer object.

$mailer = new Mailer($app['view'], $app['swift.mailer']);
// after the fix
$mailer = new Mailer($app['view'], $app['swift.mailer'], $app['events']);

Can you please fix that?

@shoaibnawaz shoaibnawaz changed the title mailer.sending event does work with laraveldkim mailer.sending event does not work with laraveldkim Dec 9, 2015
@judgej
Copy link
Member

judgej commented Dec 9, 2015

Would you be able to provide a pull request? I'd be happy to merge and make a release.

Which version of laravel are you using? Version 4.1 (IIRC) is the highest I've used this with.

@shoaibnawaz
Copy link
Contributor Author

I am using it on 4.2.
I have sent the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants