Skip to content

Commit cb30062

Browse files
jojochuangbasapuram-kumar
authored andcommitted
HADOOP-18155. Refactor tests in TestFileUtil
1 parent cb1690a commit cb30062

File tree

1 file changed

+2
-36
lines changed
  • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs

1 file changed

+2
-36
lines changed

hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java

Lines changed: 2 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -773,42 +773,8 @@ public void testUnZip() throws Exception {
773773
File foo5 = new File(tmp, "foo_5");
774774
File foo6 = new File(tmp, "foo_6");
775775
// check result:
776-
assertTrue(foo0.exists());
777-
assertTrue(foo1.exists());
778-
assertTrue(foo2.exists());
779-
assertTrue(foo3.exists());
780-
assertTrue(foo4.exists());
781-
assertTrue(foo5.exists());
782-
assertTrue(foo6.exists());
783-
assertEquals(12, foo0.length());
784-
// tests whether file foo_0 has executable permissions
785-
assertTrue("file lacks execute permissions", foo0.canExecute());
786-
assertFalse("file has write permissions", foo0.canWrite());
787-
assertFalse("file has read permissions", foo0.canRead());
788-
// tests whether file foo_1 has writable permissions
789-
assertFalse("file has execute permissions", foo1.canExecute());
790-
assertTrue("file lacks write permissions", foo1.canWrite());
791-
assertFalse("file has read permissions", foo1.canRead());
792-
// tests whether file foo_2 has executable and writable permissions
793-
assertTrue("file lacks execute permissions", foo2.canExecute());
794-
assertTrue("file lacks write permissions", foo2.canWrite());
795-
assertFalse("file has read permissions", foo2.canRead());
796-
// tests whether file foo_3 has readable permissions
797-
assertFalse("file has execute permissions", foo3.canExecute());
798-
assertFalse("file has write permissions", foo3.canWrite());
799-
assertTrue("file lacks read permissions", foo3.canRead());
800-
// tests whether file foo_4 has readable and executable permissions
801-
assertTrue("file lacks execute permissions", foo4.canExecute());
802-
assertFalse("file has write permissions", foo4.canWrite());
803-
assertTrue("file lacks read permissions", foo4.canRead());
804-
// tests whether file foo_5 has readable and writable permissions
805-
assertFalse("file has execute permissions", foo5.canExecute());
806-
assertTrue("file lacks write permissions", foo5.canWrite());
807-
assertTrue("file lacks read permissions", foo5.canRead());
808-
// tests whether file foo_6 has readable, writable and executable permissions
809-
assertTrue("file lacks execute permissions", foo6.canExecute());
810-
assertTrue("file lacks write permissions", foo6.canWrite());
811-
assertTrue("file lacks read permissions", foo6.canRead());
776+
Verify.exists(new File(tmp, "foo"));
777+
assertEquals(12, new File(tmp, "foo").length());
812778

813779
final File regularFile =
814780
Verify.createNewFile(new File(tmp, "QuickBrownFoxJumpsOverTheLazyDog"));

0 commit comments

Comments
 (0)