Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apksparser returns incorrect error when target SDK is missing #691

Open
lberrymage opened this issue Oct 24, 2024 · 0 comments
Open

apksparser returns incorrect error when target SDK is missing #691

lberrymage opened this issue Oct 24, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lberrymage
Copy link
Member

apksparser currently returns an error indicating it can't find an app's version name when in reality the issues is that it can't find the target SDK. The offending code is found here:

parcelo/apksparser/src/main/kotlin/app/accrescent/parcelo/apksparser/ApkSet.kt

Lines 244 to 245 in 6a74d57

targetSdk = targetSdk
?: return ParseApkSetResult.Error.VersionNameNotFoundError,

We should correct this to return a more appropriate error code and message.
@lberrymage lberrymage added the bug Something isn't working label Oct 24, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Roadmap Oct 24, 2024
@lberrymage lberrymage added the good first issue Good for newcomers label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Roadmap
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lberrymage