-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add policy set for GitHub provider #334
Conversation
Add GitHub as a new provider with the existing policy copied over from the gcp policies. Resolves #325
Tested locally via |
Codecov Report
@@ Coverage Diff @@
## master #334 +/- ##
==========================================
+ Coverage 61.42% 61.45% +0.03%
==========================================
Files 56 57 +1
Lines 1068 1069 +1
==========================================
+ Hits 656 657 +1
Misses 346 346
Partials 66 66
|
pkg/policies/opa/rego/github/github_repository/accurics.github.IAM.145.json
Outdated
Show resolved
Hide resolved
@williepaul Thanks for the feedback. Addressed your points. Let me make this one ready for review as you already gave feedback. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HorizonNet all looks good, I tested the changes out locally and they worked fine. We really appreciate the contribution!
Add GitHub as a new provider with the existing policy copied over from
the gcp policies.
Resolves #325