fix a bug when rendering subcharts #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
williepaul
commented
Nov 12, 2020
williepaul
commented
- in some cases, subcharts could not be rendered properly
- change how we render values such that default capabilities are set, preventing rendering errors
- set lintmode to true to allow ignoring of certain rendering errors from within the rendering engine
- add resource count checking to load-dir unit tests
- update error messages to make sure we are including the error data
- in some cases, subcharts could not be rendered properly - change how we render values such that default capabilities are set, preventing rendering errors - set lintmode to true to allow ignoring of certain rendering errors from within the rendering engine - add resource count checking to load-dir unit tests - update error messages to make sure we are including the error data
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 65.90% 65.95% +0.05%
==========================================
Files 80 80
Lines 1830 1830
==========================================
+ Hits 1206 1207 +1
+ Misses 521 520 -1
Partials 103 103
|
devang-gaur
suggested changes
Nov 12, 2020
| return iacDocuments, chartMap, err | ||
| } | ||
|
|
||
| // for each template file found, render and save an iacDocument | ||
| var templateFileMap map[string][]*string | ||
| templateFileMap, err = utils.FindFilesBySuffix(filepath.Join(chartDir, helmTemplateDir), h.getHelmTemplateExtensions()) | ||
| if err != nil { | ||
| logger.Warn("error while calling FindFilesBySuffix") | ||
| logger.Warn("error while calling FindFilesBySuffix", zap.Error(err)) |
There was a problem hiding this comment.
Suggested change
| logger.Warn("error while calling FindFilesBySuffix", zap.Error(err)) | |
| logger.Error("error while calling FindFilesBySuffix", zap.Error(err)) |
| .project | ||
| .idea/ | ||
| *.tmproj | ||
| .vscode/ |
There was a problem hiding this comment.
Can we also add vendor/ here?
kanchwala-yusuf
suggested changes
Nov 12, 2020
- errors were output when helm template rendering created a blank file, which is still valid yaml - the "invalid kind" message is suppressed in this case, since rendering an empty template may be intentional - error log levels and also error messages were updated per review comments
|
Kudos, SonarCloud Quality Gate passed!
|
kanchwala-yusuf
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.