-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support comment with rule skipping for resource and scan summary modifications #466
Merged
kanchwala-yusuf
merged 6 commits into
tenable:master
from
patilpankaj212:skip-comment-and-scan-summary-additions
Jan 15, 2021
Merged
support comment with rule skipping for resource and scan summary modifications #466
kanchwala-yusuf
merged 6 commits into
tenable:master
from
patilpankaj212:skip-comment-and-scan-summary-additions
Jan 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
patilpankaj212
commented
Jan 11, 2021
•
edited
Loading
edited
- support for comments with skip rule for k8s and tf
- output changes to include skipped violations and skipped rule comment (if any)
- should fix Ability to add ignore comments to code #310
- should fix How to ignore a rule? #367
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
==========================================
+ Coverage 74.84% 75.01% +0.17%
==========================================
Files 88 88
Lines 2051 2125 +74
==========================================
+ Hits 1535 1594 +59
- Misses 382 393 +11
- Partials 134 138 +4
|
patilpankaj212
changed the title
Skip comment and scan summary additions
support comment with rule skipping for resource and scan summary modifications
Jan 11, 2021
@patilpankaj212 Would you mind rebasing? |
2. skipped resource violations in output.
2. human readable output modifications
kanchwala-yusuf
force-pushed
the
skip-comment-and-scan-summary-additions
branch
from
January 15, 2021 16:31
23a1e7a
to
6530dc8
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
kanchwala-yusuf
approved these changes
Jan 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.