Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support comment with rule skipping for resource and scan summary modifications #466

Conversation

patilpankaj212
Copy link
Contributor

@patilpankaj212 patilpankaj212 commented Jan 11, 2021

  1. support for comments with skip rule for k8s and tf
  2. output changes to include skipped violations and skipped rule comment (if any)
  3. should fix Ability to add ignore comments to code #310
  4. should fix How to ignore a rule? #367

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #466 (6530dc8) into master (9ac1b32) will increase coverage by 0.17%.
The diff coverage is 82.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   74.84%   75.01%   +0.17%     
==========================================
  Files          88       88              
  Lines        2051     2125      +74     
==========================================
+ Hits         1535     1594      +59     
- Misses        382      393      +11     
- Partials      134      138       +4     
Impacted Files Coverage Δ
pkg/results/store.go 40.00% <37.50%> (-35.00%) ⬇️
pkg/policy/opa/engine.go 60.18% <55.00%> (-1.54%) ⬇️
pkg/utils/skip_rules.go 88.88% <84.61%> (-11.12%) ⬇️
pkg/writer/human_readable.go 84.44% <94.11%> (+26.11%) ⬆️
pkg/iac-providers/kubernetes/v1/normalize.go 90.36% <100.00%> (+2.30%) ⬆️
pkg/policy/types.go 100.00% <100.00%> (ø)
pkg/results/types.go 100.00% <100.00%> (ø)

@patilpankaj212 patilpankaj212 changed the title Skip comment and scan summary additions support comment with rule skipping for resource and scan summary modifications Jan 11, 2021
@cesar-rodriguez
Copy link
Contributor

@patilpankaj212 Would you mind rebasing?

@kanchwala-yusuf kanchwala-yusuf force-pushed the skip-comment-and-scan-summary-additions branch from 23a1e7a to 6530dc8 Compare January 15, 2021 16:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kanchwala-yusuf kanchwala-yusuf merged commit e5f74e4 into tenable:master Jan 15, 2021
@amirbenv amirbenv linked an issue Jan 15, 2021 that may be closed by this pull request
@patilpankaj212 patilpankaj212 deleted the skip-comment-and-scan-summary-additions branch May 5, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scanning Profiles How to ignore a rule? Ability to add ignore comments to code
3 participants