Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add options to specify desired categories of violations to be reported #547

Merged
merged 22 commits into from
Mar 9, 2021
Merged

feature: add options to specify desired categories of violations to be reported #547

merged 22 commits into from
Mar 9, 2021

Conversation

gaurav-gogia
Copy link
Contributor

No description provided.

@devang-gaur devang-gaur mentioned this pull request Feb 11, 2021
Closed
@codecov
Copy link

codecov bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

Merging #547 (a535016) into master (4df6ce6) will increase coverage by 0.31%.
The diff coverage is 95.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
+ Coverage   77.65%   77.97%   +0.31%     
==========================================
  Files         102      103       +1     
  Lines        2524     2565      +41     
==========================================
+ Hits         1960     2000      +40     
- Misses        420      421       +1     
  Partials      144      144
Impacted Files Coverage Δ
pkg/http-server/file-scan.go 74.28% <83.33%> (+1.01%) ⬆️
pkg/runtime/validate.go 85.71% <83.33%> (-0.29%) ⬇️
pkg/cli/run.go 91.42% <100.00%> (ø)
pkg/cli/scan.go 70.83% <100.00%> (+1.26%) ⬆️
pkg/config/config-reader.go 86.36% <100.00%> (+0.64%) ⬆️
pkg/http-server/remote-repo.go 69.64% <100.00%> (ø)
pkg/policy/opa/engine.go 65.56% <100.00%> (+1.18%) ⬆️
pkg/runtime/executor.go 90.90% <100.00%> (+0.28%) ⬆️
pkg/runtime/rules.go 100.00% <100.00%> (ø)
pkg/utils/category.go 100.00% <100.00%> (ø)
... and 2 more

devang-gaur
devang-gaur previously requested changes Feb 18, 2021
View reviewed changes
pkg/notifications/notifiers_test.go Outdated Show resolved Hide resolved
pkg/notifications/notifiers_test.go Outdated Show resolved Hide resolved
pkg/policy/opa/engine.go Show resolved Hide resolved
pkg/runtime/validate.go Show resolved Hide resolved
pkg/policy/opa/engine_test.go Show resolved Hide resolved
@gaurav-gogia gaurav-gogia added the go Pull requests that update Go code label Feb 20, 2021
gaurav-gogia and others added 21 commits March 8, 2021 16:14
@gaurav-gogia
feature: add options to specify desired categories of violations to b…
7f02e33 
…e reported
@gaurav-gogia
bugfix: signatures and spelling fix
f0391de 
executor_test.go: signatures fixed
executor.go: function name spelling fixed
rules.go: function call fixed
@gaurav-gogia
update deps
56aaccc
@gaurav-gogia
fix TerracanConfig struct
535e51e 
fix associated test
add test case for categories
@gaurav-gogia
commenting out strange test case
bc794f0
@gaurav-gogia
fixed opa engine related test cases:
b6c4b50 
category.go
1. made acceptedCategories public to be used in helper function

engine_test.go
1. added helper function for category based testing
2. added helper function for COMPLIANCE VALIDATION test case
3. added test case for COMPLIANCE VALIDATION category
@gaurav-gogia
comment describing acceptedcategories added
572991e
@gaurav-gogia
minor fix, added blank line
fb77fe6
@gaurav-gogia
reverted to continue using: pelletier/go-toml
62e3f87
@gaurav-gogia
deps updated
db3b9a9
@gaurav-gogia
minor fixes, deps updated, category added
43d11b3
@gaurav-gogia
more test cases added
14bcaa1
@gaurav-gogia
error for invalid category added
fcb5338
@gaurav-gogia
testdata files for category updated
12bf30d
@gaurav-gogia
fixed slice comparision util function
0ad71c1
@gaurav-gogia
update deps
9b380de
@gaurav-gogia
fix: indenation, ran go-fmt script
36a116e
@gaurav-gogia
updated dependencies, synced go.mod and go.sum
9ff6403
@gaurav-gogia
quick fixes
64a0d4c 
(cherry picked from commit 85d7883)
@gaurav-gogia
update golden file for help_scan
f19e4f6 
(cherry picked from commit 158e8c3)
@gaurav-gogia
add: category flag scanning e2e server tests
5da79bb 
(cherry picked from commit 9f22238)
@gaurav-gogia
add:
a535016 
1. scan e2e tests for --category flag
2. server e2e tests for category

mod:
1. server e2e terminate test

(cherry picked from commit f93fbad)
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kanchwala-yusuf kanchwala-yusuf dismissed devang-gaur’s stale review March 9, 2021 06:21

accommodated all the review comments

@kanchwala-yusuf kanchwala-yusuf merged commit a3bcac7 into tenable:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanchwala-yusuf kanchwala-yusuf kanchwala-yusuf approved these changes

@devang-gaur devang-gaur devang-gaur left review comments

@patilpankaj212 patilpankaj212 Awaiting requested review from patilpankaj212

Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaurav-gogia @devang-gaur @kanchwala-yusuf