Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category flag e2e tests #605

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Category flag e2e tests #605

merged 2 commits into from
Mar 19, 2021

Conversation

gaurav-gogia
Copy link
Contributor

No description provided.

@gaurav-gogia gaurav-gogia added the go Pull requests that update Go code label Mar 10, 2021
@gaurav-gogia gaurav-gogia self-assigned this Mar 10, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #605 (4c6169e) into master (c61f306) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #605   +/-   ##
=======================================
  Coverage   77.99%   77.99%           
=======================================
  Files         103      103           
  Lines        2568     2568           
=======================================
  Hits         2003     2003           
  Misses        421      421           
  Partials      144      144           

Copy link
Contributor

@patilpankaj212 patilpankaj212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
We should later add a test to assert on the output too.

@patilpankaj212 patilpankaj212 merged commit 55c1ae1 into tenable:master Mar 19, 2021
@gaurav-gogia gaurav-gogia deleted the category_flag_e2e_tests branch May 21, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants