fix panic for floating point variables #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 77.91% 77.94% +0.02%
==========================================
Files 105 105
Lines 2604 2607 +3
==========================================
+ Hits 2029 2032 +3
Misses 427 427
Partials 148 148
|
| @@ -58,7 +64,7 @@ func ctyToSlice(ctyVal cty.Value) (interface{}, error) { | |||
| var val []interface{} | |||
| var allErrs error | |||
|
|
|||
| if strings.Contains(ctyVal.Type().FriendlyName(), "list") { | |||
| if ctyVal.Type().IsListType() { | |||
There was a problem hiding this comment.
Just curious, does IsListType() give a more reliable and consistent output?
kanchwala-yusuf
approved these changes
Apr 12, 2021
|
@patilpankaj212 , was wondering if we could add a sample terraform config in our unit tests for testing this particular case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #652