Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update version #713

Merged
merged 1 commit into from
Apr 29, 2021
Merged

update version #713

merged 1 commit into from
Apr 29, 2021

Conversation

chenrui333
Copy link
Contributor

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #713 (3a522ea) into master (a09b879) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #713   +/-   ##
=======================================
  Coverage   73.28%   73.28%           
=======================================
  Files         110      110           
  Lines        3099     3099           
=======================================
  Hits         2271     2271           
  Misses        650      650           
  Partials      178      178
Impacted Files Coverage Δ
pkg/version/version.go 100.00% <ø> (ø)

jlk
jlk approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@jlk jlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@jlk
Copy link
Contributor

jlk commented Apr 29, 2021

Thanks @chenrui333. We're working on a release checklist so we don't make basic mistakes like this.

@jlk jlk merged commit d8fd9c4 into tenable:master Apr 29, 2021
@chenrui333
Copy link
Contributor Author

Thanks @chenrui333. We're working on a release checklist so we don't make basic mistakes like this.

no worries at all. :)

@chenrui333 chenrui333 deleted the patch-1 branch April 30, 2021 02:51
devang-gaur pushed a commit to devang-gaur/terrascan that referenced this pull request May 5, 2021
@chenrui333 @devang-gaur
update version (tenable#713)
6bba11c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlk jlk jlk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @jlk