Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question (history): should there be empty history records? #1361

Open
gythaogg opened this issue Nov 12, 2024 · 1 comment
Open

question (history): should there be empty history records? #1361

gythaogg opened this issue Nov 12, 2024 · 1 comment
Assignees

Comments

@gythaogg
Copy link
Contributor

gythaogg commented Nov 12, 2024

This happens when when I go to the edit view and then "Submit" without making any changes

And another scenario when this happens is when the Relations models are not versioned (as is the case with the sample project) and I create a new relation for the entity. This is probably an edge case - but overall it would be nice to not create history entries when there is nothing to diff.

@gythaogg gythaogg added the needs-attention This issue or pull request is in need of discussion, information, assessment by team members label Nov 12, 2024
@sennierer
Copy link
Collaborator

Created a test that shows that behaviour. Empty history are removed when running a managemenet command, but an empty history entry shouldnt be created in the first place. I will see how to fix that

@gythaogg gythaogg removed the needs-attention This issue or pull request is in need of discussion, information, assessment by team members label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants