Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectator still running while session is lost #2592

Closed
Cuel opened this issue Sep 24, 2015 · 7 comments
Closed

Spectator still running while session is lost #2592

Cuel opened this issue Sep 24, 2015 · 7 comments
Assignees
Labels
Milestone

Comments

@Cuel
Copy link
Contributor

Cuel commented Sep 24, 2015

ACE3 Version: 3.3.2
stable

Mods:

  • @CBA_A3
  • @ace

Description:
https://d.maxfile.ro/icrboxhrwk.webm

Steps to reproduce:

  1. Join dedicated server
  2. Go into spectator
  3. Force-end the server

Where did the issue occur?
MP

@PabstMirror PabstMirror added this to the Ongoing milestone Sep 24, 2015
@PabstMirror
Copy link
Contributor

I've noticed something similar with nametags, I think draw/PFEH can continue to run after mission ended.

I should look into

addMissionEventHandler ["Ended",{ }];

@commy2
Copy link
Contributor

commy2 commented Sep 24, 2015

addMissionEventHandler ["Ended", {removeAllMissionEventHandlers "Loaded"}];

Does that mean that Mission eventhandlers run after the mission has ended?

@kymckay
Copy link
Member

kymckay commented Sep 25, 2015

This is interesting because the dialog's "unload" event should kill the EH

removeMissionEventHandler ["Draw3D",GVAR(iconHandler)];

I suppose maybe because the mission has ended that command fails or something

@kymckay
Copy link
Member

kymckay commented Sep 25, 2015

Oh wait, the actual camera and everything is still running...huh, that's a new one. I knew about the icon rendering stuff.

@kymckay
Copy link
Member

kymckay commented Sep 25, 2015

Assuming it works, this could theoretically be solved with:

addMissionEventHandler ["Ended",{ [false] call FUNC(setSpectator) }];

@kymckay kymckay self-assigned this Oct 4, 2015
@kymckay
Copy link
Member

kymckay commented Oct 17, 2015

Can anyone test whether the spectatorUpdates branch fixes this? 😄

@kymckay
Copy link
Member

kymckay commented Nov 4, 2015

My unit are currently re-hosting my spectator updates and it didn't seem to persist on mission end during last weeks session.

If anyone else can also test then that'd be great, but I'll consider it a success for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants