FixFloating Error

[jonpas]

ACE3 Version: 3.3.2.0 f77242f (latest master)

The below error pops up when releasing a carried or dragged object of specific type - in this case a chair, for example Land_CampingChair_V2_F, happens with other chairs as well. Apparently it's because they don't have hitpoints.

2:00:48 Error in expression <arams ["_array", "_code"];


_array = + _array;

{
_array set [_forEachIndex, _x>
 2:00:48   Error position: <_array;

{
_array set [_forEachIndex, _x>
 2:00:48   Error foreach: Undefined variable in expression: _array
 2:00:48 File z\ace\addons\common\functions\fnc_map.sqf, line 7
 2:00:48 Error in expression <n_fnc_getHitpoints;
_hitPointDamages = [_hitPoints, {_object getHitPointDamage _>
 2:00:48   Error position: <_hitPoints, {_object getHitPointDamage _>
 2:00:48   Error Undefined variable in expression: _hitpoints
 2:00:48 File z\ace\addons\common\functions\fnc_fixFloating.sqf, line 14

[jonpas]

Invalid, I was actually not on latest master, damn you Git 🍌

[PabstMirror]

Drag/carry doesn't seem to be enabled for those chairs, should it?

[jonpas]

No, but I was adding it for #2620 if there are objections, write it there of course. :)

This issue has been fixed by #2601 for reference.

[PabstMirror]

Excellent, was just checking because I didn't see them.

[commy2]

This is not fixed in master. It is however fixed in #2598.

Commit: 1de3343#diff-9bb10d0be40dd380ce136f7f6a480058R24

It was introduced when I replaced the stuff in FUNC(getHitpoints) with getAllHitpointsDamage.

getAllHitpointsDamage is supposed to return an array containing 3 arrays:
[[<HITPOINTS>],[<SELECTIONS>],[<DAMGE_VALUES>]],
but when used on an object without any hitpoints it simply returns [] instead of [[],[],[]], which I consider as a bug personally. I missed that in my testing initially.

Btw.
https://community.bistudio.com/wiki/getAllHitPointsDamage
claims that the return value is a number.

[jonpas]

Well, I am not getting the error after I merged master into my branch (and realised I am behind before that), so it must have been something in master that fixed that particular case.

That BI wiki page says "Return Value: Array" for me.

[commy2]

Oh yes. NVM, fixed that particular case in #2601. Root cause isn't fixed though. At least in master.