Check for trench possibility inverted on some maps

[Lujan1405]

Arma 3 Version: current (stable)
CBA Version: 3.4.1 (stable / dev + commit hash)
ACE3 Version: 3.10.2 (stable / dev + commit hash)

Mods:

- CBA_A3
- ace
- CUP Terrains Complete
- Celle

Description:

• On some maps (noticed again today on Celle) the check if you are able to dig a trench is inverted. It is possible to dig up the streets but not to put a trench down on the grass next to it. This only occurs on some maps with Celle beeing one of them (I´ll check tomorrow for the others we had that issue and update if needed)

https://imgur.com/a/k8p3A

Steps to reproduce:

• Set a player on celle
• Give him the entrenching tool
• Try to dig a trench on the streets vs on the grass

Where did the issue occur?

• Dedicated / Self-Hosted Multiplayer / Singleplayer / Editor (Singleplayer) / Editor (Multiplayer)

Placed Modules:

• None

RPT log file:

• https://pastebin.com/5hNVkEhW

[Lujan1405]

Okay. I just got a few minutes so i tested Altis, Beketow and the CUP Bystrica.

Altis is the same like Celle. Trench possible on streets. Not on grass.
Beketow is kinda strange. Uploaded the images under the following link (will add further pics there)
Bystrica is kinda special too. Picture is there too:

https://imgur.com/a/bgpYp

I´ll test some more maps from cup some mod-maps and all four vanillas asap

[commy2]

https://github.com/acemod/ACE3/blob/master/addons/common/functions/fnc_canDig.sqf#L31
This is the logic used. Streets tend to be very dusty and grass not so much. Maybe should work more with the white- and blacklist.
https://github.com/acemod/ACE3/blob/master/addons/common/script_component.hpp#L24-L36

[Lujan1405]

Okay that explains why it is allowed on the streets of bystrica but not on the sidewalk. getposATL select 2 on the sidewalk is 0.1.

And on altis there is a lot of "drygrass" which might be needed in the whitelist.

But i am currently standing on Alits in a "green" area (surfacetype is "grass") and i still cant dig.
https://imgur.com/z7bj9hw
https://imgur.com/JWLfQqF

[jonpas]

Altis streets and grass:

22:23:15 [ACE] (common) TRACE: 50956 Surface: _surfaceType=dirt, _surfaceDust=0.5 z\ace\addons\common\functions\fnc_canDig.sqf:30

Not too sure what to do about streets, method we use uses soundEnviron entry which returns dirt in this case.
Grass was fixed (whitelisted "grass") in #5453 which will be released with 3.11.0.

Bystrica streets:

22:27:44 [ACE] (common) TRACE: 69877 Surface: _surfaceType=normalExt, _surfaceDust=0.1 z\ace\addons\common\functions\fnc_canDig.sqf:30

Blacklist surface type seems to be the best solution.

Don't have Celle or Beketov downloaded now, but if you can get me surface types and see if some other surface you shouldn't be able to dig on doesn't have the same one (like Altis streets), I'll fix/improve it.

Moving to post-3.11.0 update for now.

[kymckay]

We just need the surface types to blacklist in order to fix this, going to set milestone to ongoing until we know them.

[jonpas]

Unassigning myself, don't have time to look into those maps myself.

[Rod6er]

Ok so I asked the map maker for beketov and here are the surface types
http://pastebin.com/aTt1C38U

[Mike-MF]

Closing due to age, inactivity or already solved. May be re-opened if the issue is still present, even better just open a new up-to-date Issue.