Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom in/out action of compass on map broken by ace_map #6200

Closed
severgun opened this issue Mar 18, 2018 · 16 comments
Closed

Zoom in/out action of compass on map broken by ace_map #6200

severgun opened this issue Mar 18, 2018 · 16 comments

Comments

@severgun
Copy link
Contributor

severgun commented Mar 18, 2018

Arma 3 Version: 1.80 (stable)
CBA Version: 3.5 (stable)
ACE3 Version: 3.12.1 (stable)

Mods:

- CBA_A3
- ace

Description:

  • Zoom in/out action of compass on map broken by ace_map. Once you double click and move it, you can't zoom in/out it again, because Arma overwrite position[] and positionBack[] at Arma3Profile on disk.

Steps to reproduce:

  • Double click on compass, move it around, double click again and again and again.

Where did the issue occur?

  • Everywhere

Placed Modules:

  • none

Solution

@commy2
Copy link
Contributor

commy2 commented Mar 18, 2018

Isn't this intentional?

@severgun
Copy link
Contributor Author

What intentional? Line 102 make it bigger. But you can stuck with zoomed out which is not readable. And all your efforts in line 102 went to hell.

So IMHO author want make it bigger and disable animation of resizing. But zero value gives undefined behavior.

@PabstMirror
Copy link
Contributor

compass

Vanilla Small
Vanilla Big
ACE Normal (it's locked to this size)
ACE - Big (keep scale change, but allow zooming)

            scale = 0.7;
            // zoomDuration = 0;

So I guess we wanted to remove the compass zooming and just leave it the big size all the time.
ACE does make it as big as you could get from vanilla
There does seem to be some weirdness in the profile, I think people would have to change it to fix zooming.

@PabstMirror PabstMirror added this to the Ongoing milestone Mar 21, 2018
@severgun
Copy link
Contributor Author

I can't get why not to allow zoom action? Why compass should stay at one size?
Also zoomDuration did not disable zoom action even if it was desired.

Now it can stuck at vanilla small.

@jonpas
Copy link
Member

jonpas commented Mar 22, 2018

Because zooming compass is broken in the game. It can get stuck in small mode.

@commy2
Copy link
Contributor

commy2 commented Mar 22, 2018

Isn't this also about the ruler being scaled correctly?

@severgun
Copy link
Contributor Author

severgun commented Mar 22, 2018

Because zooming compass is broken in the game. It can get stuck in small mode.

I have no stuck issues with mine fixed(or vanilla zoomDuration) version and 100% reproducible yours.
¯\(ツ)

@commy2
Copy link
Contributor

commy2 commented Mar 22, 2018

Not a bug, close?

@severgun
Copy link
Contributor Author

BIS Fault?
How to reproduce stuck on vanilla?

@commy2
Copy link
Contributor

commy2 commented Mar 22, 2018

Never heard of that. It doesn't scale so it fits the map grid.

@stale
Copy link

stale bot commented Nov 18, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale label Nov 18, 2018
@stale stale bot removed the status/stale label Nov 18, 2018
@barman75
Copy link
Contributor

barman75 commented Jul 7, 2019

Still no solution?
I have to edit class Compass in *.Arma3Profile file every time ACE breaks the code, to fix the position and size.

@commy2
Copy link
Contributor

commy2 commented Jul 7, 2019

It's not an issue, so there can be no solution.

@severgun
Copy link
Contributor Author

severgun commented Jul 8, 2019

Still no solution?

Solution in ticket. Just create your own pbo which will overwrite ACE "feature".
zoomDuration = 0.3; Looks more pleasant to eye than 0.1

@dedmen
Copy link
Contributor

dedmen commented Jan 15, 2021

Arma stores the compass position and size in front and back mode (zoomed in and out)
This ace feature of changing the transition duration to instant (which i wouldn't consider a important feature, 0.1 or 0.3 seconds sounds just fine to me?) breaks this Arma feature and can cause Arma to store the same position for both front and back, meaning you'll forever get stuck in either zoomed, or unzoomed and double clicking doesn't do anything as the other zoom mode has the exact same size stored in Arma profile.

This is an issue for every Control with zoomable object (its a base UI component) so BI cannot add a compass specific workaround for it.

When I checked on that issue a few weeks ago I could find about half a dozen people with the same problem of not being able to zoom their compass within a few hours, all of them running ACE.
And they get stuck at that point for ever, unloading ACE also doesn't fix it.

@jonpas
Copy link
Member

jonpas commented Apr 20, 2021

Fixed by #8176.

@jonpas jonpas closed this as completed Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants