Fix(explosives): Selecting a cellphone as an IEDs trigger would throw an error #5963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bux
changed the title
bux
changed the title
|
Btw I broke that private thingy 💃 |
PabstMirror
reviewed
Dec 23, 2017
| @@ -19,6 +19,9 @@ | |||
| params ["_unit"]; | |||
| TRACE_1("params",_unit); | |||
|
|
|||
| // close cellphone if open | |||
| closeDialog 0; | |||
There was a problem hiding this comment.
runs on all local units
if (_unit == ace_player) then {
PabstMirror
approved these changes
Dec 23, 2017
kymckay
reviewed
Dec 23, 2017
| private _codeSet = false; | ||
|
|
||
| while {!_codeSet} do { |
There was a problem hiding this comment.
Alternative:
private _code = "";
while {true} do {
_code = [round(random 9999),4] call EFUNC(common,numberToDigitsString);
if (([_code] call FUNC(getSpeedDialExplosive)) isEqualTo []) exitWith {};
};
Closed
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
… an error (#5963) * move code var to outer scope * run closeDialog only for the player
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
_codevar to outer scope, close IED not linkable with cellphone #5808