Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Intel Items: Suggestions for Improvement #233

Open
Drofseh opened this issue May 8, 2020 · 6 comments
Open

Intel Items: Suggestions for Improvement #233

Drofseh opened this issue May 8, 2020 · 6 comments
Assignees

Comments

@Drofseh
Copy link

Drofseh commented May 8, 2020

Is your enhancement related to a problem?
I'm setting up some intel items for a mission and I've encountered a couple of things that I feel could use QOL improvements.

Solution you'd like:

  1. Documentation
    Right now there is no documentation on the Ace3 Wiki. A small entry that mentions how the 3DEN Attributes for the items work (will they accept structured text, what filepaths can be used for the photo item) and gives an example of acex_intelitems_fnc_addIntel would be nice.

  2. Inventory Management
    Because of the limited number of item classes available to use when I have more than one of the same class I can't know which intel item I will drop when I want to pass it to another person.
    For example, if item X and item Y are both acex_intelitems_notepad and I want to give someone only item Y there is no way for me to know which will be dropped.

    Possible solutions would be to add an ace interaction node to drop the item, or to use unique classes and serialize them in the same way that ACRE2 does with radios. A serialized solution could also make use of Item Rename Framework CBATeam/CBA_A3#1329.

  3. Pickup Interaction
    Right now the condition for picking up the items includes a check for inventory space.
    This made me think the addon wasn't working properly until I realized my inventory was full leaving no room for the item.
    I think it would be better to have the condition to pick to be true and have the inventory space check happen in the statement, if not enough room is found then output a hint saying so.

@mharis001 mharis001 self-assigned this May 8, 2020
@Drofseh
Copy link
Author

Drofseh commented May 8, 2020

The following objects could also be considered for inclusion in this system:

DocumentsSecret
FileNetworkStructure
FileTopSecret
Files
FilesSecret
Files_diary
Files_researchNotes
Intel_File1_F
Intel_File2_F
Intel_Photos_F
Land_Laptop_Intel_01_F
Land_Laptop_Intel_02_F
Land_Laptop_Intel_Oldman_F
Land_PCSet_Intel_01_F
Land_PCSet_Intel_02_F
Land_Wallet_01_F

They are all vanilla objects.

@Drofseh
Copy link
Author

Drofseh commented May 11, 2020

The ability to run code to display different messages on the same item would be nice as well.

My use case here is that I want display different messages based on a players ACRE language.

@stale
Copy link

stale bot commented Nov 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 7, 2020
@mharis001 mharis001 removed the stale label Nov 7, 2020
@severgun
Copy link
Contributor

severgun commented Jan 6, 2021

I think it would be better to have the condition to pick to be true and have the inventory space check happen in the statement, if not enough room is found then output a hint saying so.

Or change icon/color of pickup action if not enough space.

@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 8, 2021
@Drofseh
Copy link
Author

Drofseh commented Jul 8, 2021

Bad bot

@stale stale bot removed the stale label Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants