Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nifti files are stored under mincpath #4197

Closed
driusan opened this issue Dec 12, 2018 · 2 comments
Closed

nifti files are stored under mincpath #4197

driusan opened this issue Dec 12, 2018 · 2 comments
Assignees
Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation

Comments

@driusan
Copy link
Collaborator

driusan commented Dec 12, 2018

I noticed while reviewing #4096 that .nii and .nii.gz files are both using the mincPath configuration setting for the location to store them.

This makes the configuration name confusing and should probably be cleaned up.

@cmadjar
Copy link
Collaborator

cmadjar commented Jan 3, 2019

@driusan Looking at the Config paths, there is a lot of redundancy and I think this could be cleaned up: mincPath = data = imagePath = dataDirBasepath

  • imagePath used by get_file.php, tool generate_project_statistics_csv.php, php/installer/Installer.class.inc, mri_violations.class.inc, API 0.0.2 and 0.0.3-dev (candidates/visits/images/format/Thumbnail.php) and imaging_install.sh
  • data does not appear to be used anywhere in the LORIS code...
  • mincPath used by php/installer/Installer.class.inc, brainbrowser image.php, get_file.php, API 0.0.2 and 0.0.3-dev (candidates/visits/images/Image.php) and imaging_install.sh
  • dataDirBasepath used by the imaging pipelines (under section Imaging Pipeline)

Will bring it up at the next Imaging meeting so we can decide as a group what to do with it but we should probably just use the imagePath one.

@cmadjar cmadjar self-assigned this Jan 3, 2019
@cmadjar
Copy link
Collaborator

cmadjar commented Jan 18, 2019

Discussed during the LORIS-MRI meeting of January 18th. Will keep only the dataDirBasepath field in the Config module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation
Projects
None yet
Development

No branches or pull requests

2 participants