[Dicom archive] Module should use site-based permissions

[nicolasbrossard]

Describe the bug
Currently, if you have access to the DICOM archive module, you can see all DICOM archives, even those not associated to your site(s). It would make more sense if the DICOM archive module used site-based permissions, just like the MRI violations and imaging browser modules.

[cmadjar]

@nicolasbrossard I think this is by design that you can see all DICOM archives. The reason for it is in case an archive is not associated to a site (aka - invalid patient name that does not allow to associate the study to a candidate/visit).

If I remember correctly, I believe the site-based permissions were added at some point but then some DICOM studies did not show in the DICOM archive module because of the lack of site associated to the study and then it was removed but I am not entirely sure that my memory is fully correct though ;).

[nicolasbrossard]

@cmadjar The way I implemented this in the MRI violations module is that if a violation is not associated to any site, everybody can see it. Maybe we can do the same thing here to be consistent?

[cmadjar]

@nicolasbrossard smart :). Is that something you can work on eventually? Otherwise we'll find someone else to do it. Just let us know.

[nicolasbrossard]

@cmadjar Yeah, I can do this.

[nicolasbrossard]

This still needs to be done as of 2024SEP18.