Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrument] missing error message when Linst Form won't save due to BasicDate field #7656

Closed
christinerogers opened this issue Sep 30, 2021 · 3 comments
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Category: Bug PR or issue that aims to report or fix a bug

Comments

@christinerogers
Copy link
Contributor

When a BasicDate field is required due to a Xin rule, and left empty, and the Linst Form (correctly) doesn't save --
the user has to re-check every field in the form because no error message appears near the BasicDate field.

This is frustrating to users and may lead to data loss.

e.g. in this sequence of questions :
(1) Was the Surgery done? (yes/no/not_answered) -> user selects "yes"
(2) What date was the surgery? (BasicDate) --> left empty.
And there is a XIN rule in place: (2) date is required iff (1) surgery done== "yes"

In this case, the XIN rule triggers correctly, and the Form doesn't save (correctly) and an error message is printed at top (Form was not saved) -- but there's no way to tell which field caused the error.
The user has to re-check every field in the form.

Note StandardDate can't be used instead, because of another bug #7650

@christinerogers christinerogers added the Category: Bug PR or issue that aims to report or fix a bug label Sep 30, 2021
@christinerogers christinerogers changed the title [Instrument] no Required error on BasicDate fields when Linst Form won't save [Instrument] missing error message when Linst Form won't save due to BasicDate field Oct 1, 2021
@christinerogers
Copy link
Contributor Author

might be resolved by #7266 - to be verified

@ridz1208
Copy link
Collaborator

@christinerogers was it verified ?

@ridz1208 ridz1208 added the 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 label Nov 16, 2021
@christinerogers
Copy link
Contributor Author

I haven't tested on main, but as an override on a 23 install this pr fixed the issue.

@cmadjar cmadjar closed this as completed Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Category: Bug PR or issue that aims to report or fix a bug
Projects
None yet
Development

No branches or pull requests

3 participants