Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModuleManager] when it's set to Active:no - page fails to load #9245

Open
christinerogers opened this issue May 9, 2024 · 4 comments
Open
Assignees
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)

Comments

@christinerogers
Copy link
Contributor

Basically this module should never be configured to Active:No -- but it should still fail a bit more elegantly here on the off chance it is.

currently it loads with a blank page saying "this module could not be found" if it's set to Active:no (in the modules table i think)

found during C-BIg testing may 9. filed a bug after discussion with @ridz1208 and Dave.

@christinerogers christinerogers added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label May 9, 2024
@driusan
Copy link
Collaborator

driusan commented May 9, 2024

The problem isn't that it fails when Active='N', the problem is that it fails when it's not on the file system (even if it's inactive)

@ridz1208
Copy link
Collaborator

ridz1208 commented May 9, 2024

@driusan maybe it can be a try catch to get the module info and if it fails it can just replace with NA or some other message

@sruthymathew123 sruthymathew123 self-assigned this May 16, 2024
@christinerogers
Copy link
Contributor Author

still seems like an important bug (did not test)

@sruthymathew123
Copy link
Contributor

@driusan @christinerogers I agree that this module shouldn't be set No; But I am getting the below attached attached message when set to 'No'..

Image

What is the fix we need to implement here. I am little confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

No branches or pull requests

4 participants