You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Currently when instantiating an instrument with a Test_name and CommentID, the CommentID does not have to belong to the same instrument as the Test_name. As long as the Test_name exists in the database, it can be used as an argument for any CommentID.
There should be a warning or error thrown in these cases to ensure that the right Test_name is being passed as an argument to the factory method.
The text was updated successfully, but these errors were encountered:
CamilleBeau
added
the
Bug
PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
label
Jul 30, 2024
What is the current behaviour if they don't match/how is this coming up?
@driusan If they don't match, it makes the instrument from the CommentID. This is coming up because we were making a script on CCNA that should have failed during testing as CommentIDs were being matched with different Test_names, but it did not.
Describe the bug
Currently when instantiating an instrument with a Test_name and CommentID, the CommentID does not have to belong to the same instrument as the Test_name. As long as the Test_name exists in the database, it can be used as an argument for any CommentID.
There should be a warning or error thrown in these cases to ensure that the right Test_name is being passed as an argument to the factory method.
The text was updated successfully, but these errors were encountered: