-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding thousands separators #204
Comments
And how to do this in Windows? |
WDYM? The same solution would work for any OS |
"A quick solution and easy solution is available - just format the printed numbers with an available library of your choice." I can't find that solution you are claiming that exists! Happy New Year! |
https://stackoverflow.com/questions/13020308/how-to-fmt-printf-an-integer-with-thousands-comma/46811454 |
Thanks for the suggestion! I've seen this request a few times so I'll add it to the roadmap. go-humanize or something similar along with commas will likely be needed to compensate for the additional characters. |
I would be willing to try to tackle this problem if you are looking for some help. |
Please make the separator character user configurable. Remember that different cultures have different ways of doing this. |
Adding this shouldn't be too difficult but the wrinkle is that each value would take up more room due to the commas so there should be some testing done around the edge cases there + how this interacts with the scale suffix. The problem is also partially addressed by the scale suffix @yodigi7 a PR would be welcome if you're interested in having a look. @clauseggers agreed this should be configurable |
The current version shows longs numbers in a non human readable notation where long numbers are presented without thousands separators.
vs
A quick solution and easy solution is available - just format the printed numbers with an available library of your choice.
The text was updated successfully, but these errors were encountered: