Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding thousands separators #204

Open
wavenator opened this issue Dec 6, 2021 · 8 comments
Open

Adding thousands separators #204

wavenator opened this issue Dec 6, 2021 · 8 comments
Labels
feature request New feature or request

Comments

@wavenator
Copy link

The current version shows longs numbers in a non human readable notation where long numbers are presented without thousands separators.

7453823

vs

7,453,823

A quick solution and easy solution is available - just format the printed numbers with an available library of your choice.

@zohozer
Copy link

zohozer commented Dec 28, 2021

And how to do this in Windows?

@wavenator
Copy link
Author

WDYM? The same solution would work for any OS

@zohozer
Copy link

zohozer commented Dec 31, 2021

"A quick solution and easy solution is available - just format the printed numbers with an available library of your choice."

I can't find that solution you are claiming that exists!

Happy New Year!

@wavenator
Copy link
Author

@achannarasappa
Copy link
Owner

Thanks for the suggestion! I've seen this request a few times so I'll add it to the roadmap.

go-humanize or something similar along with commas will likely be needed to compensate for the additional characters.

@achannarasappa achannarasappa added this to the future-release milestone Jan 17, 2022
@achannarasappa achannarasappa added the feature request New feature or request label Jan 17, 2022
@yodigi7
Copy link

yodigi7 commented Jun 22, 2023

I would be willing to try to tackle this problem if you are looking for some help.

@clauseggers
Copy link

Please make the separator character user configurable. Remember that different cultures have different ways of doing this.

@achannarasappa
Copy link
Owner

Adding this shouldn't be too difficult but the wrinkle is that each value would take up more room due to the commas so there should be some testing done around the edge cases there + how this interacts with the scale suffix. The problem is also partially addressed by the scale suffix

@yodigi7 a PR would be welcome if you're interested in having a look.

@clauseggers agreed this should be configurable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants