Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Propagate results and errors to task awaiters in ptaskgroup #44

Merged
merged 15 commits into from
Mar 10, 2022

Conversation

achimnol
Copy link
Owner

  • This allows the caller can await and handle exceptions in the task
    if they want to, beside the persistent task group's owne exception
    handler.

* This allows the caller can await and handle exceptions in the task
  if they want to, beside the persistent task group's owne exception
  handler.
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #44 (d5ce553) into main (cc4ba30) will decrease coverage by 0.42%.
The diff coverage is 48.57%.

❗ Current head d5ce553 differs from pull request most recent head e737f4c. Consider uploading reports for the commit e737f4c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   65.96%   65.54%   -0.43%     
==========================================
  Files          16       16              
  Lines        1281     1306      +25     
==========================================
+ Hits          845      856      +11     
- Misses        436      450      +14     
Impacted Files Coverage Δ
src/aiotools/taskgroup/persistent.py 0.00% <0.00%> (ø)
src/aiotools/taskgroup/persistent_compat.py 83.33% <94.44%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc4ba30...e737f4c. Read the comment docs.

@achimnol achimnol changed the title feat: Propagate errors to awaiters of tasks in ptaskgroup feat: Propagate results and errors to task awaiters in ptaskgroup Mar 10, 2022
@achimnol achimnol merged commit 6b0f425 into main Mar 10, 2022
@achimnol achimnol deleted the feature/propagate-ptaskgroup-task-error-to-await branch March 10, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant