feat!: support stubbed properties as well as methods #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the method map passed to `stubInterface` and friends to be a `Partial` of the stubbed type. This way we can pass values for properties and `Sinon.stub`s for methods, which is usually better since we freqently want to stub behaviour as well as return types which we can't do when we're just passing values. BREAKING CHANGE: method map values must now be wrapped in `Sinon.stub().returns()`
achingbrain
force-pushed
the
feat/support-properties-as-well-as-methods
branch
from
f39f2fb
to
e2bae34
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
## [2.0.0](v1.0.2...v2.0.0) (2023-11-01) ### ⚠ BREAKING CHANGES * method map values must now be wrapped in `Sinon.stub().returns()` ### Features * support stubbed properties as well as methods ([#12](#12)) ([42413b2](42413b2))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the method map passed to
stubInterfaceand friends to be aPartialof the stubbed type.This way we can pass values for properties and
Sinon.stubs for methods, which is usually better since we freqently want to stub behaviour as well as return types which we can't do when we're just passing values.BREAKING CHANGE: method map values must now be wrapped in
Sinon.stub().returns()