-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use subpath imports to choose Node or vanilla JS environment #88
Conversation
FYI @achingbrain we've seen this come up a few more times with Ceramic users, would be great to get this in if possible. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 99.26% 99.34% +0.07%
==========================================
Files 16 22 +6
Lines 547 612 +65
Branches 102 106 +4
==========================================
+ Hits 543 608 +65
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ukstv I've made a couple of changes:
Can you take a look at the updates please? |
cc @wemeetagain for more eyeballs |
It is amazing @achingbrain !! ❤️ |
## [5.0.3](v5.0.2...v5.0.3) (2024-03-13) ### Bug Fixes * Use subpath imports to choose Node or vanilla JS environment ([#88](#88)) ([e43f1f4](e43f1f4))
🎉 This PR is included in version 5.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I'm pretty sure it's related, but since this got merged, I've been having problems using packages that depend on this package in Codesandbox with Parcel. example The error I get:
I suppose this is bundler dependent and I haven't tried to debug this too much, so any pointers would be helpful. |
@2color Indeed, this is bundler-dependent. Parcel AFAIK still relies on explicit opt-in to enable subpath imports/exports. parcel-bundler/parcel#7840 (comment) and https://parceljs.org/features/dependency-resolution/#package-exports tell if you add
to |
The changes here address #87
Note FYI: There is no indication of a package manager used. If using PNPM, which is slightly more strict than NPM, some of the transitive dependencies from aegir like
@types/mocha
,@types/node
,mocha
are considered to be unavailable. The PR has no related changes.