Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that all plugins used by configs are listed as peer dependencies #180

Closed
G-Rath opened this issue Oct 10, 2021 · 1 comment · Fixed by #188
Closed

Ensure that all plugins used by configs are listed as peer dependencies #180

G-Rath opened this issue Oct 10, 2021 · 1 comment · Fixed by #188
Assignees
Labels
enhancement New feature or request released

Comments

@G-Rath
Copy link
Contributor

G-Rath commented Oct 10, 2021

We should be including all plugins used by our configs as peer dependencies, to make it easier to get a working config (since package managers will at least warn if a peer dependency version doesn't match our constraints).

Currently we're only listing required peer dependencies aka those that are used by the standard config, but we should also be listing the plugins used by our optional/extra configs using peerDependenciesMeta to mark the dependencies as optional.

We'll want to have a test that ensures all plugins used by each config is listed as a peer dependency, and that they're marked as optional or not as appropriate.

We will also need to update generate-configs-list to handle optional dependencies.

@G-Rath G-Rath added the enhancement New feature or request label Oct 10, 2021
@G-Rath G-Rath self-assigned this Oct 14, 2021
@G-Rath G-Rath added bug Something isn't working enhancement New feature or request and removed enhancement New feature or request bug Something isn't working labels Oct 14, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant