Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollapsibleCard eliminate 'editMode' #1092

Open
jamiek-acl opened this issue Jun 30, 2021 · 0 comments
Open

CollapsibleCard eliminate 'editMode' #1092

jamiek-acl opened this issue Jun 30, 2021 · 0 comments
Labels
Editor's Choice Highlight an issue as something that would be great to be solve Low Priority ↓

Comments

@jamiek-acl
Copy link
Contributor

Nahum made a comment in a ticket: https://aclgrc.atlassian.net/browse/UXD-1095?focusedCommentId=302052

can we remove the concept of isEditing prop in the current CollpasibleCard? and switched it for kind={CollapsibleCard.types.kind.inter'ctive} using the concept isEditing don't let room for the component to expand and grow, isEditing is only relevant or make sense during a feature design but doesn't have any functionality in the component apart from just setting the header colour into yellow.

Removing the concept of editing mode and bringing up the concept for kind gives room to the component to grow organically, for example, if we need a state to mark the card with an error, or if it’s on loading state, we could use the kind property as we use it in the Toast. The other way we will have to incorporate hasError, which doesn’t describe at all what is happening inside of the CollapsibleCard.

This is part of designing agnostic components and preventing to tide them and mixed them with business logic

@oscarkwan oscarkwan added the Editor's Choice Highlight an issue as something that would be great to be solve label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editor's Choice Highlight an issue as something that would be great to be solve Low Priority ↓
Projects
None yet
Development

No branches or pull requests

2 participants