You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
can we remove the concept of isEditing prop in the current CollpasibleCard? and switched it for kind={CollapsibleCard.types.kind.inter'ctive} using the concept isEditing don't let room for the component to expand and grow, isEditing is only relevant or make sense during a feature design but doesn't have any functionality in the component apart from just setting the header colour into yellow.
Removing the concept of editing mode and bringing up the concept for kind gives room to the component to grow organically, for example, if we need a state to mark the card with an error, or if it’s on loading state, we could use the kind property as we use it in the Toast. The other way we will have to incorporate hasError, which doesn’t describe at all what is happening inside of the CollapsibleCard.
This is part of designing agnostic components and preventing to tide them and mixed them with business logic
The text was updated successfully, but these errors were encountered:
Nahum made a comment in a ticket: https://aclgrc.atlassian.net/browse/UXD-1095?focusedCommentId=302052
The text was updated successfully, but these errors were encountered: