Feature request: support waterfox

[dpicassom]

Hi, Great extension and application! I found out that the /opt/vdhcoapp/vdhcoapp install script won't register waterfox, dunno if other firefox based browsers like librewolf would be added, hopefully it's possible.

[paulrouget]

waterfox & co should work as long as they read the standard ~/.mozilla/native-messaging-hosts/ directory. If they don't, I need to know which profile dir they use.

Also I need to know if they use any sandboxing mechanism (snap/flatpak/apparmor).

Here is a simple test:

# Stop waterfox
mkdir p ~/.waterfox/
cp -r ~/.mozilla/native-messaging-hosts ~/.waterfox
# start waterfox

If this works, I'll add support for waterfox.

[MorganLOCode]

How about for Windows builds? VDH worked for Waterfox up until 2.0.10, since which it can't find the newly-installed coapp (note this also means it can't check licensing).

This extension does not have permission to use native application net.downloadhelper.coapp (or the application is not installed).

[paulrouget]

How about for Windows builds? VDH worked for Waterfox up until 2.0.10, since which it can't find the newly-installed coapp (note this also means it can't check licensing).

If you can find which Windows registry it's using, I'll gladly add it to the installer. For Firefox, it's "Software\Mozilla\NativeMessagingHost".

[MorganLOCode]

Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Mozilla\NativeMessagingHosts\net.downloadhelper.coapp
value
C:\Program Files\net.downloadhelper.coapp\firefox.net.downloadhelper.coapp.json

I reverted VDH on Waterfox to 8.0.0.6 and installed the 1.6.3 version of the coapp to find this key. The value is the location of that version of the coapp.

Thing is, the newer version of the coapp is installed, and Firefox itself is using it fine.

[paulrouget]

That key should have been updated the the new json path. I'm surprised.

That's definitively a bug.

I'll look into it.

[MorganLOCode]

For what it's worth, updating that registry value manually to point to C:\Program Files\DownloadHelper CoApp\mozilla.json does make everything work.

(But where is Firefox getting its value from if it's not here...?)

[paulrouget]

@MorganLOCode do you use a 32bits machine or a 64bits machine?

I think you use Firefox 32 bits with a coapp 64 bits.

I added some notes here about the Registry Base, do you mind taking a look?

https://github.com/aclap-dev/vdhcoapp/blob/master/doc/Troubleshooting.md#windows-coapp-not-found-by-extension

[MorganLOCode]

Both browsers are 64-bit.

Querying the registry, both keys point to the same (correct) path as in my previous post (but remember I manually altered one of them).

Ah: just checked. Firefox is using the registry key in the WOW6432Node branch, Waterfox is using the other one.

[paulrouget]

That means your Waterfox is a 32bits build, not 64bits. Which is not surprising to me.

[paulrouget]

Install the 32bits coapp if you want to get this to work properly, or install waterfox 64bits.

[MorganLOCode]

Ah, not quite:

"Modern" Waterfox installs it properly when I tried it, but not "Classic". That's the distinction. I have a bunch of reasons for still using Classic (and using two browsers is part of keeping a hard distinction between two work roles) and forgot that there was a "Modern/Classic" divergence.

Weirdly, WOW6432Node is supposed to be the branch used by 32-bit applications on 64-bit platforms; why 64-bit Firefox is using it 🤷

[paulrouget]

Ok, it's the same bug as #201.

[milahu]

waterfox & co should work as long as they read the standard ~/.mozilla/native-messaging-hosts/ directory. If they don't, I need to know which profile dir they use.

librewolf per keepassxreboot/keepassxc#6907

-  ~/.mozilla/native-messaging-hosts
+  ~/.librewolf/native-messaging-hosts

vdhcoapp/config.toml

Line 189 in 0b40d3e

"~/.mozilla/native-messaging-hosts/",

this would be so much simpler with a vdhcoapp.config.js
currently you have to copy all mozilla configs, and replace "mozilla" with "librewolf"

[OrvilleRed]

Librewolf Flatpak user on Linux here.

I did this to Make It Work:

cd ~/.local/share/flatpak/overrides
cp org.mozilla.firefox io.gitlab.librewolf-community
cd ~/.var/app
mkdir -p .gitlab.librewolf-community/.librewolf/native-messaging-hosts
cp org.mozilla.firefox/.mozilla/native-messaging-hosts/net.downloadhelper.coapp.json io.gitlab.librewolf-community/.librewolf/native-messaging-hosts/net.downloadhelper.coapp.json