Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to refresh detection? #225

Open
rsalmei opened this issue May 23, 2024 · 10 comments
Open

How to refresh detection? #225

rsalmei opened this issue May 23, 2024 · 10 comments

Comments

@rsalmei
Copy link

rsalmei commented May 23, 2024

After downloading something from a streaming website, the original content keeps playing, of course. And I can't download a new portion of it without first refreshing the page...
The detected video is gone as soon as we press download, changed into a downloading handle, and when we click stop there are two cases:

  • with "Automatically hide downloaded media", it simply vanishes from screen, making the popup empty (but the original video keeps playing).
  • without it, the popup only shows a handle to play that newly downloaded video, which I find useless.

In any case, I can't download it again. How to make the download handle reappear?
Is it possible for it to automatically reappear in case the video is still streaming? If not, how about a Refresh button?
By the way, a Refresh button would nicely complement the Clean and Clean All buttons, one undoing the other.
Thanks!

@paulrouget
Copy link
Member

How to make the download handle reappear?

On the left of the Play button, there's a retry button:

Screenshot 2024-05-24 at 09 40 19

@rsalmei
Copy link
Author

rsalmei commented May 27, 2024

Thanks, but unfortunately, it is not the same behavior.
By clicking Retry, the entire frame won't hide again, they will simply stay there on the list even after changing the selected tab. And, after only two or three plus their downloaded ones, the list quickly starts to pile up and become unmanageable. I can barely find the newly detected ones on a new tab anymore.

@rsalmei
Copy link
Author

rsalmei commented May 27, 2024

When a download is finished, all it would take is to auto-refresh the list of detected videos.

Or, just allow us to show a Refresh button in it:
image

We can already optionally show Clean buttons, which I don't particularly appreciate as I prefer auto-hiding to keep it clean, but a Refresh button is surprisingly missing:
image

@paulrouget
Copy link
Member

I'm not exactly sure to understand what you want.

You want a button to re-detect videos in that page? Refreshing the page itself doesn't do the tric?

@rsalmei
Copy link
Author

rsalmei commented May 29, 2024

Yes, it does, but it's a much more expensive action. It would be much faster if only the addon could do a refresh instead of the whole page, which also has to reconnect chat and video.
I've been doing this, but I don't know why, after a few times it makes my Firefox stop connecting altogether.

@paulrouget
Copy link
Member

paulrouget commented May 30, 2024

Do you mind sharing from which website you're downloading?

On twitch, this seems to work as you want.

@rsalmei
Copy link
Author

rsalmei commented Jun 18, 2024

Hi @paulrouget.

Actually, not. I just tested on twitch, on a live stream, and it doesn't work.

For example, I downloaded a portion of a live stream here: https://www.twitch.tv/alanzoka
It generated alanzoka - Twitch.mp4, and now the popup is empty:
image
So, to grab another portion, I have to refresh the whole page.

If I uncheck "Automatically hide downloaded media", it does show the previous video where I can click re-download, but with a BIG caveat:
image

If I change tabs now (I have to use several tabs at the same time), the above previous video SHOWS THERE TOO:
image
And it quickly becomes overwhelming and unmanageable:
image

And what if I click re-download now?? Yikes, it is even worse:
image

  1. the previously downloaded video doesn't go away,
  2. a new entry is added to download it again
  3. and these entries show in every single tab I select...

I hope that helps to understand the problem.
I just wanted to keep tabs isolated, hiding content generated or available on other tabs, and being able to simply download a new portion of a stream without refreshing the page.

@paulrouget
Copy link
Member

the previously downloaded video doesn't go away,

You can always click on the "x", no?

a new entry is added to download it again

Yes.

and these entries show in every single tab I select...

Yes, I know about this. It's actually necessary, but I think I can work around that issue.

I'll work on improving the Twitch integration. I understand it's not great at the moment.

@rsalmei
Copy link
Author

rsalmei commented Jun 19, 2024

I can click on x, sure, but there may be several downloads running at the same time, so it's not that easy to find it. And, I already click STOP, there shouldn't be another required click.

That's why "Automatically hide downloaded media" is the best option for me. This keeps tabs completely isolated from each other.

All that is needed for me is a simpler way to show the video again on the pop up, so I can download it again. It is streaming after all.
If not automatically, at least a button for doing it manually. Anything that doesn't require reloading the whole website page.
Thank you!

@paulrouget
Copy link
Member

Ok, I get you! Thank you for the details and all.

I want to improve the unknown-length streaming situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants