Fix unit tests

Author: devksingh4

tests/unit/functions/github.test.ts

@@ -53,7 +53,7 @@ describe("createGithubTeam", () => {
 
     const result = await createGithubTeam(defaultInputs);
 
-    expect(result).toBe(existingTeamId);
+    expect(result).toStrictEqual({ updated: false, id: existingTeamId });
     expect(mockLogger.info).toHaveBeenCalledWith(
       `Team "Test Team" already exists with id: ${existingTeamId}`
     );
@@ -81,7 +81,7 @@ describe("createGithubTeam", () => {
 
     const result = await createGithubTeam(defaultInputs);
 
-    expect(result).toBe(newTeamId);
+    expect(result).toStrictEqual({ updated: true, id: newTeamId });
     expect(mockOctokit.request).toHaveBeenCalledWith("POST /orgs/{org}/teams", {
       org: "test-org",
       name: "Test Team",
@@ -157,7 +157,7 @@ describe("createGithubTeam", () => {
 
     const result = await createGithubTeam(defaultInputs);
 
-    expect(result).toBe(newTeamId);
+    expect(result).toStrictEqual({ updated: true, id: newTeamId });
     expect(mockLogger.warn).toHaveBeenCalledWith(
       `Failed to remove user from team ${newTeamId}:`,
       expect.any(Error)

tests/unit/organizations.test.ts

@@ -16,9 +16,6 @@ import { createJwt } from "./auth.test.js";
 import { marshall } from "@aws-sdk/util-dynamodb";
 import { genericConfig } from "../../src/common/config.js";
 import { randomUUID } from "node:crypto";
-import { createGithubTeam } from "../../src/api/functions/github.js";
-import { addLead, removeLead } from "../../src/api/functions/organizations.js";
-import { modifyGroup } from "../../src/api/functions/entraId.js";
 
 const app = await init();
 const ddbMock = mockClient(DynamoDBClient);
@@ -48,17 +45,6 @@ vi.mock("../../src/api/functions/entraId.js", () => {
     }),
   };
 });
-vi.mock("../../src/api/functions/github.js", () => {
-  return {
-    ...vi.importActual("../../src/api/functions/github.js"),
-    createGithubTeam: vi.fn().mockImplementation(async () => {
-      return randomUUID();
-    }),
-    assignIdpGroupsToTeam: vi.fn().mockImplementation(async () => {
-      return;
-    }),
-  };
-});
 
 const acmMeta = {
   primaryKey: "DEFINE#ACM",
@@ -417,16 +403,6 @@ describe("Organization info tests - Extended Coverage", () => {
       expect(
         ddbMock.commandCalls(TransactWriteItemsCommand).length,
       ).toBeGreaterThan(0);
-      expect(createGithubTeam).toHaveBeenCalledOnce();
-      expect(createGithubTeam).toHaveBeenCalledWith(
-        expect.objectContaining({
-          githubToken: "abc123testing",
-          orgId: "acm-uiuc-testing",
-          name: "social-adm-nonprod",
-          description: "Social Committee Admin",
-          parentTeamId: 14420860,
-        }),
-      );
     });
 
     test("Successfully adds and removes Officers but skips Entra + GitHub integration", async () => {
@@ -489,8 +465,6 @@ describe("Organization info tests - Extended Coverage", () => {
       expect(
         ddbMock.commandCalls(TransactWriteItemsCommand).length,
       ).toBeGreaterThan(0);
-      expect(createGithubTeam).toHaveBeenCalledTimes(0);
-      expect(modifyGroup).toHaveBeenCalledTimes(0);
     });
 
     test("Organization lead can manage other leads", async () => {