Skip to content

Commit 0965d4b

Browse files
iamAbhi-916Abhijeet Jhavineethkuttan
authored andcommitted
Fix : Incorrect view access to obtain ContentIsland from for the DesktopPopupSiteBridge (microsoft#14628)
* solved access read violation due to incorrect view access to obtain contentIsland * rolling back text.tsx * Update end of line text.tsx * rolled back Playground-Composition.vcxproj * rolled back Playground-Composition.vcxproj * fixed lint Playground-Composition.vcxproj * master Playground-Composition.vcxproj * rolled back Playground-Composition.vcxproj * indentation fix Playground-Composition.vcxproj * Revert unintended changes in Playground-Composition.vcxproj * added patch for winUiex[erimental removal * Change files --------- Co-authored-by: Abhijeet Jha <abhijeetjha@microsoft.com> Co-authored-by: Vineeth <66076509+vineethkuttan@users.noreply.github.com>
1 parent f54d1a2 commit 0965d4b

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "none",
3+
"comment": "solved access read violation due to incorrect view access to obtain contentIsland",
4+
"packageName": "react-native-windows",
5+
"email": "abhijeetjha@microsoft.com",
6+
"dependentChangeType": "none"
7+
}

vnext/Microsoft.ReactNative/Fabric/Composition/Modal/WindowsModalHostViewComponentView.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ struct ModalHostView : public winrt::implements<ModalHostView, winrt::Windows::F
231231

232232
m_popUp = winrt::Microsoft::UI::Content::DesktopPopupSiteBridge::Create(
233233
portal.Parent()
234-
.Parent()
235234
.as<winrt::Microsoft::ReactNative::Composition::ComponentView>()
236235
.Root()
237236
.ReactNativeIsland()

0 commit comments

Comments
 (0)