Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude patches from merge? #1074

Closed
timwood opened this issue Feb 10, 2017 · 1 comment
Closed

Exclude patches from merge? #1074

timwood opened this issue Feb 10, 2017 · 1 comment
Labels
Enhancement A feature or feature request

Comments

@timwood
Copy link

timwood commented Feb 10, 2017

Is it possible to exclude patches from composer merge like how you can exclude dependencies as documented in http://blt.readthedocs.io/en/8.x/readme/updating-blt/#modifying-update-behavior ?

My system information:

  • Operating system type: Mac OS
  • Operating system version: 10.11.6
  • BLT version: 8.6.11

When I run this command:

blt update

composer.json gets updated with the following patch even though I've added acquia/lightning to composer-exclude-merge.

+            "acquia/lightning": {
+                "New LightningExtension subcontexts do not autoload": "https://www.drupal.org/files/issues/2836258-3-lightning-extension-autoload.patch"
+            }

Should patches be added for a project that is excluded and if so, is there any harm in BLT adding them and leaving them there?

Related to #613

@grasmash grasmash added the Enhancement A feature or feature request label Feb 14, 2017
@grasmash
Copy link
Contributor

I've just merged an update that will use the https://github.com/wikimedia/composer-merge-plugin to manage pulling in default values from BLT's templated composer.json. You should be able to define your own patches array to override BLT's now. You could also optionally disable the merging of the extra section and instead define your own values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

No branches or pull requests

2 participants