Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty-print changes to composer.lock #134

Closed
danepowell opened this issue Feb 10, 2021 · 2 comments
Closed

Pretty-print changes to composer.lock #134

danepowell opened this issue Feb 10, 2021 · 2 comments

Comments

@danepowell
Copy link
Contributor

danepowell commented Feb 10, 2021

Changes to composer.lock are essentially impossible for humans to parse, which can and has led to unintended changes on multiple projects.

https://github.com/davidrjonas/composer-lock-diff is a plugin that pretty-prints these changes. I've implemented a PoC of this in some of our closed-source projects to pretty-print the diff in Travis CI and it works great! I can't share a direct link here but the changes required are minimal:
screenshot-github com-2021 02 10-07_53_12

And here's the output:
screenshot-travis-ci com-2021 02 10-07_43_53

Could we get this in ORCA?

As a bonus/follow-up feature, I think it would be nice to actually append this output as a comment on any Github PR that modifies composer.lock so it's more visible and not buried in Travis CI. But even in the current form it's still really useful.

@TravisCarden
Copy link
Contributor

Adding this to our internal Jira backlog as ORCA-212.

@Raksha-Bharuka
Copy link
Contributor

Closing this issue because it has been inactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants