Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Allow warnings to pass phpcs #79

Closed
kaynenh opened this issue Mar 31, 2020 · 2 comments
Closed

[Feature Request] Allow warnings to pass phpcs #79

kaynenh opened this issue Mar 31, 2020 · 2 comments

Comments

@kaynenh
Copy link

kaynenh commented Mar 31, 2020 •
edited
Loading

The Content Hub module is currently failing phpcs with the following error (4 times):

 1 | WARNING | File appears to be minified and cannot be
   |         | processed (Internal.Tokenizer.Exception)

These warnings are generated from 2 minified css and 2 minified js files, so they are definitely not something we want phpcs even sniffing.

Could we change the severity of warnings so that they do not fail phpcs? Thanks for considering!
@kaynenh
Copy link
Author

kaynenh commented Apr 2, 2020

Removing minified css/js from code sniffing would also be enough to fix this, so this issue may be enough: #63

@Raksha-Bharuka
Copy link
Contributor

Closing this issue because it has been inactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaynenh @Raksha-Bharuka